Customizable links on home and footer - #1125
Conversation
| @@ -0,0 +1,19 @@ | |||
| <section id="additional_links"> | |||
| <ul class="catalogue"> | |||
There was a problem hiding this comment.
This may be a controversial choice to reuse the catalogue css classes for the additional links.
There was a problem hiding this comment.
I think it's OK, unless you can think of a better name for the CSS class that applies to both uses...
There was a problem hiding this comment.
I couldn't think of a better name, instead I added an extra class which allows more intuitive theming separate from the catalogue feature.
fbacall
left a comment
There was a problem hiding this comment.
Looks good, but could you add a test with each one of the settings used?
See test/controllers/static_controller_test.rb for examples
| @@ -0,0 +1,19 @@ | |||
| <section id="additional_links"> | |||
| <ul class="catalogue"> | |||
There was a problem hiding this comment.
I think it's OK, unless you can think of a better name for the CSS class that applies to both uses...
Summary of changes
Configurable arbitrary links
Also adds an html id attribute to the sections on the screen where it is still missing.
Motivation and context
Part of mTeSS-x project to allow further customization of different instances. (In particular relevant for PaN Training to allow imprint link in footer and links to wiki and e-learning on home.)
Screenshots
The example contains the configured links "Access Courses", "PaN Wiki" and "Test":

The example contains the configured links "Imprint" and "Test"

Checklist
to license it to the TeSS codebase under the
BSD license.