Skip to content

Customizable links on home and footer - #1125

Merged
fbacall merged 15 commits into
ElixirTeSS:masterfrom
eilmiv:customizable-links-on-home-and-footer
Aug 1, 2025
Merged

Customizable links on home and footer#1125
fbacall merged 15 commits into
ElixirTeSS:masterfrom
eilmiv:customizable-links-on-home-and-footer

Conversation

@eilmiv

@eilmiv eilmiv commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

Summary of changes

Configurable arbitrary links

  • in footer
  • as boxes on home screen including some icon or logo
  • extended funder logos on footer and about/us by option to only show logo in either place
    • e.g. to have the dark version of a logo in the footer while the light version is on the about/us page
    • e.g. to only have logo on about/us page if there are too many

Also adds an html id attribute to the sections on the screen where it is still missing.

Motivation and context

Part of mTeSS-x project to allow further customization of different instances. (In particular relevant for PaN Training to allow imprint link in footer and links to wiki and e-learning on home.)

Screenshots

The example contains the configured links "Access Courses", "PaN Wiki" and "Test":
image

The example contains the configured links "Imprint" and "Test"
Screenshot from 2025-07-09 12-11-14

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@@ -0,0 +1,19 @@
<section id="additional_links">
<ul class="catalogue">

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a controversial choice to reuse the catalogue css classes for the additional links.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK, unless you can think of a better name for the CSS class that applies to both uses...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't think of a better name, instead I added an extra class which allows more intuitive theming separate from the catalogue feature.

@fbacall fbacall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you add a test with each one of the settings used?

See test/controllers/static_controller_test.rb for examples

@@ -0,0 +1,19 @@
<section id="additional_links">
<ul class="catalogue">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK, unless you can think of a better name for the CSS class that applies to both uses...

@eilmiv
eilmiv marked this pull request as draft July 30, 2025 11:43
@eilmiv
eilmiv marked this pull request as ready for review July 30, 2025 13:37
@fbacall
fbacall merged commit 966ba98 into ElixirTeSS:master Aug 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants