Use thinned build - #606
Merged
Merged
Conversation
📸 Snapshot Test1 modified, 71 unchanged
🛸 Powered by Emerge Tools |
noahsmartin
force-pushed
the
useThinnedBuild
branch
from
September 30, 2025 21:26
1e37de3 to
976c6e5
Compare
noahsmartin
force-pushed
the
useThinnedBuild
branch
from
September 30, 2025 21:38
976c6e5 to
7a013fe
Compare
trevor-e
approved these changes
Sep 30, 2025
| lane :build_upload_emerge do | ||
| load_asc_api_key | ||
| prepare_signing | ||
| build_app_for_scheme(build_configuration: ENV['CONFIGURATION']) |
Member
Author
There was a problem hiding this comment.
yep that param wasn't used anywhere in the build_app_for_scheme function
jamieQ
added a commit
that referenced
this pull request
Aug 5, 2026
Follow up to #835. The change in #835 to upload a thinned IPA for size analysis "worked", but unfortunately lost dSYM info. Upon further investigation, it appears we used to have both things working (implemented in #606), but that regressed recently. This change re-implements an approach closer to the original strategy, where we produce a thinned export, but then replace the original XCArchive payload with the thinned payload before uploading. This way we upload the thinned payload and retain the dSYM through the process. Now the uploads have debug info in the binary analysis: <img width="66%" height="787" alt="thin-dsyms" src="https://github.com/user-attachments/assets/9c9fa11e-bf1e-4391-8417-c4fde455c47d" /> Refs EME-1285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.