fix(ios): Export thinned IPA for size analysis - #835
Merged
Conversation
Use a release-testing export because Xcode ignores thinning for App Store exports. Require the requested device variant instead of falling back to a universal IPA. Refs EME-1285
📲 Install BuildsiOS
|
jamieQ
marked this pull request as ready for review
August 4, 2026 19:49
NicoHinderling
approved these changes
Aug 4, 2026
jamieQ
added a commit
that referenced
this pull request
Aug 5, 2026
Follow up to #835. The change in #835 to upload a thinned IPA for size analysis "worked", but unfortunately lost dSYM info. Upon further investigation, it appears we used to have both things working (implemented in #606), but that regressed recently. This change re-implements an approach closer to the original strategy, where we produce a thinned export, but then replace the original XCArchive payload with the thinned payload before uploading. This way we upload the thinned payload and retain the dSYM through the process. Now the uploads have debug info in the binary analysis: <img width="66%" height="787" alt="thin-dsyms" src="https://github.com/user-attachments/assets/9c9fa11e-bf1e-4391-8417-c4fde455c47d" /> Refs EME-1285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS PR Size Analysis workflow now creates a
release-testingexport with the ad hoc profiles and uploads only the IPA explicitly identified as the requested device variant. The normal archive remains an App Store Connect export, and the workflow passes the Apple team ID explicitly.Previously, the lane requested thinning during an App Store export, where Xcode ignores the option, then fell back to the first IPA it found. The export now requires
app-thinning.plistand the requested device descriptor, so it fails instead of silently uploading a universal IPA.Here's an earlier "release" build prior to this change vs after the change in the Sentry UI. You can see the duplicate asset catalog images are now "thinned" in builds we upload for size analysis:
Refs EME-1285