Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 5, 2022

Bumps jfmengels/elm-review-unused from 1.1.8 to 1.1.27.

Changelog

Sourced from jfmengels/elm-review-unused's changelog.

1.1.27 - 2022-09-19

This release contains HUGE performance updates. Rough benchmarks show some of the slow rules ([NoUnused.Exports], [NoUnused.CustomTypeConstructors] and [NoUnused.CustomTypeConstructorArgs]) are now 20-40 times faster compared to the previous release.

[1.1.26] - 2022-09-11

  • Fixed an issue in [NoUnused.Dependencies] that led the elm.json to become corrupt

[1.1.25] - 2022-09-10

  • [NoUnused.Patterns] now reports multiple aliases (((A a) as y) as z)
  • [NoUnused.Patterns] now reports aliases on a variable pattern (name as otherName)
  • [NoUnused.Patterns] now reports aliases to wildcard (_ as thing) in parameters, and [NoUnused.Parameters] now doesn't
  • Improved the fixes for [NoUnused.Patterns] to not include unnecessary patterns
  • Improved the fixes for [NoUnused.Patterns] to have formatting look more like elm-format

[1.1.24] - 2022-09-02

  • [NoUnused.Variables] now reports imports that get shadowed by other imports ([252475888b79a88f107571c1002d0ed650622ddb])

[1.1.23] - 2022-08-24

This version merges the [NoUnused.Modules] into the [NoUnused.Exports] rule.

A common issue when running elm-review --fix (or --fix-all) was when you had the two rules enabled and encountered an unused module.

While in fix mode, NoUnused.Exports would remove every export one at a time, which would likely be followed by [NoUnused.Variables] removing the previously exported element. This would go on until the module is as empty as it can be. At this point, you would finally be able to see NoUnused.Modules's error indicating that the module is unused.

Whether you want to remove the module or use it somewhere in response to this message, this is a lot of unnecessary work for you and/or the tool, making --fix-all painfully long.

By having the NoUnused.Exports do the work of both rules, and not reporting any unused exports when the entire module is unused, this situation should not happen anymore, or not as exacerbated.

[NoUnused.Modules] is therefore now deprecated and should not be used anymore. It is removed from the example configuration.

[1.1.22] - 2022-04-14

  • Fixed an issue in [NoUnused.Variables] where removing a let declaration would not always remove its type annotation ([24237116ada98791d8ff79630ca5d4eb632ef6ea])

Missing changelog

Help would be appreciated to fill the blanks!

... (truncated)

Commits
  • ff02ba2 1.1.27
  • 2f3387c Speed up NoUnused.Parameters
  • b18295a Speed up NoUnused.Modules
  • 35684b2 Speed up NoUnused.CustomTypeConstructorArgs
  • 85d88c9 Speed up NoUnused.CustomTypeConstructors
  • 020995c Speed up isMainFunction
  • c3c07df Speed up typesUsedInDeclaration
  • 875900f Speed up collectExposedElements
  • 2820d26 Speed up foldProjectContexts
  • 6ada3f5 Speed up fromModuleToProject
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels Oct 5, 2022
@bdukes
Copy link
Member

bdukes commented Oct 5, 2022

@dependabot rebase

Bumps [jfmengels/elm-review-unused](https://github.com/jfmengels/elm-review-unused) from 1.1.8 to 1.1.27.
- [Release notes](https://github.com/jfmengels/elm-review-unused/releases)
- [Changelog](https://github.com/jfmengels/elm-review-unused/blob/master/CHANGELOG.md)
- [Commits](jfmengels/elm-review-unused@1.1.8...1.1.27)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review-unused
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@bdukes bdukes force-pushed the dependabot/elm/review/jfmengels/elm-review-unused-1.1.27 branch from e42631d to c4b4bb6 Compare October 5, 2022 13:42
@bdukes bdukes merged commit 0ea86d7 into master Oct 5, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 5, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dependabot dependabot bot deleted the dependabot/elm/review/jfmengels/elm-review-unused-1.1.27 branch October 5, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file elm Pull requests that update Elm code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants