Speed up Fast Reorder Mode and make it default#1653
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
============================================
+ Coverage 11.78% 11.80% +0.02%
- Complexity 1054 1055 +1
============================================
Files 801 801
Lines 32690 32699 +9
Branches 3799 3801 +2
============================================
+ Hits 3852 3860 +8
+ Misses 28651 28650 -1
- Partials 187 189 +2
Continue to review full report at Codecov.
|
octylFractal
approved these changes
Jan 26, 2021
MattBDev
pushed a commit
to MattBDev/WorldEdit
that referenced
this pull request
Jun 30, 2021
* Speed up Fast Reorder Mode and make it default * Make non-exposed side effects internal * Docs on isExposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the fast reorder mode slightly faster than the multi-stage one by not duplicating effort with a few things. Also make it the default, due to being faster and more reliable (especially with mods).
Not entirely happy with impl yet.