Skip to content

Speed up Fast Reorder Mode and make it default#1653

Merged
me4502 merged 3 commits into
masterfrom
chore/make-fast-reorder-mode-default
Jan 26, 2021
Merged

Speed up Fast Reorder Mode and make it default#1653
me4502 merged 3 commits into
masterfrom
chore/make-fast-reorder-mode-default

Conversation

@me4502

@me4502 me4502 commented Jan 25, 2021

Copy link
Copy Markdown
Member

Makes the fast reorder mode slightly faster than the multi-stage one by not duplicating effort with a few things. Also make it the default, due to being faster and more reliable (especially with mods).

Not entirely happy with impl yet.

@me4502
me4502 requested a review from a team January 25, 2021 11:26
@codecov

codecov Bot commented Jan 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1653 (62b5217) into master (69b1b5e) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1653      +/-   ##
============================================
+ Coverage     11.78%   11.80%   +0.02%     
- Complexity     1054     1055       +1     
============================================
  Files           801      801              
  Lines         32690    32699       +9     
  Branches       3799     3801       +2     
============================================
+ Hits           3852     3860       +8     
+ Misses        28651    28650       -1     
- Partials        187      189       +2     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/sk89q/worldedit/EditSession.java 0.86% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/com/sk89q/worldedit/LocalSession.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...orldedit/command/argument/SideEffectConverter.java 38.46% <0.00%> (-7.00%) 2.00 <0.00> (ø)
...k89q/worldedit/internal/wna/WorldNativeAccess.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/com/sk89q/worldedit/util/SideEffect.java 25.92% <0.00%> (-4.51%) 0.00 <0.00> (ø)
...dedit/util/formatting/component/SideEffectBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/com/sk89q/worldedit/session/SessionManager.java 15.64% <0.00%> (+5.44%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b1b5e...dde2695. Read the comment docs.

@me4502
me4502 merged commit 5aa81ff into master Jan 26, 2021
@me4502
me4502 deleted the chore/make-fast-reorder-mode-default branch January 26, 2021 05:57
MattBDev pushed a commit to MattBDev/WorldEdit that referenced this pull request Jun 30, 2021
* Speed up Fast Reorder Mode and make it default

* Make non-exposed side effects internal

* Docs on isExposed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants