Skip to content

Properly support fluids - #3003

Merged
me4502 merged 3 commits into
masterfrom
feature/proper-fluid-support
Aug 9, 2026
Merged

Properly support fluids#3003
me4502 merged 3 commits into
masterfrom
feature/proper-fluid-support

Conversation

@me4502

@me4502 me4502 commented Aug 8, 2026

Copy link
Copy Markdown
Member

This PR adds proper FluidState/FluidType/FluidCategory support, migrating our historic partial registries to be fully featured as well as adding FluidState as a derived BlockState property.

This allows us in the future to support features such as #3001, as the way to differentiate those blocks is to use fluid states.

This PR purely exposes the fluid system within our API, it does not add any features using those fluids at this point.

@me4502
me4502 marked this pull request as ready for review August 8, 2026 06:07
@me4502
me4502 requested a review from a team as a code owner August 8, 2026 06:07
@me4502 me4502 added this to the 8.0.0 milestone Aug 8, 2026
Comment thread worldedit-core/src/main/java/com/sk89q/worldedit/world/fluid/FluidState.java Outdated

@octylFractal octylFractal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is, we'll look at cleaning it up later alongside BlockState.

@me4502

me4502 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Follow-up issue for cleanup: #3006

@me4502
me4502 merged commit 6e148b7 into master Aug 9, 2026
3 checks passed
@me4502
me4502 deleted the feature/proper-fluid-support branch August 9, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants