Skip to content

Dev.ej/refactor hfg - #595

Merged
joanise merged 2 commits into
dev.ap/fix-model-namefrom
dev.ej/refactor_hfg
Nov 26, 2024
Merged

Dev.ej/refactor hfg#595
joanise merged 2 commits into
dev.ap/fix-model-namefrom
dev.ej/refactor_hfg

Conversation

@joanise

@joanise joanise commented Nov 26, 2024

Copy link
Copy Markdown
Member

@semanticdiff-com

semanticdiff-com Bot commented Nov 26, 2024

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/cli.py  6% smaller
  everyvoice/model/vocoder/HiFiGAN_iSTFT_lightning  0% smaller

@github-actions

Copy link
Copy Markdown
Contributor
CLI load time: 0:00.29
Pull Request HEAD: 773a3a14eeaf62b747df112fcd6b58caa67f043b
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       254 |     107695 |   typer
import time:      6414 |     224119 | everyvoice.cli

@SamuelLarkin SamuelLarkin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joanise
joanise merged commit 8608240 into dev.ap/fix-model-name Nov 26, 2024
@joanise
joanise deleted the dev.ej/refactor_hfg branch November 26, 2024 19:30
@codecov

codecov Bot commented Nov 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (945ccb6) to head (773a3a1).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           dev.ap/fix-model-name     #595   +/-   ##
======================================================
  Coverage                  76.58%   76.59%           
======================================================
  Files                         46       46           
  Lines                       3451     3452    +1     
  Branches                     470      470           
======================================================
+ Hits                        2643     2644    +1     
  Misses                       706      706           
  Partials                     102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants