[No QA] Add images to Expensify Card articles - #100116
Conversation
Removed unnecessary HTML div tag and added an image to the troubleshooting guide.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@chuckdries @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -121,6 +121,8 @@ Each card shows one of the following statuses: | |||
|
|
|||
| **Note:** The **Status** column is hidden on narrow and medium screens. Widen your browser window or view the list on a larger screen to see it. | |||
|
|
|||
There was a problem hiding this comment.
Alt text defect: The parenthesis is unbalanced — (Pending order, Shipped, Active, Inactive] opens with ( but never closes it before ]. Add the closing paren: ...showing the badges (Pending order, Shipped, Active, Inactive).
| keywords: [Expensify Card, card declined, Smart Limit, inactive card, activation issues, card won’t work, workspace admin, cardholder, Wallet, domain limit] | ||
| --- | ||
|
|
||
| <div id="new-expensify" markdown="1"> |
There was a problem hiding this comment.
Structural regression: Removing the opening <div id="new-expensify" markdown="1"> leaves the matching closing </div> (near the end of the file) orphaned, producing invalid HTML. Either restore this opening tag or also remove the trailing </div>.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a31bbb3ca9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| <div id="new-expensify" markdown="1"> | ||
|
|
||
| You can troubleshoot most Expensify Card issues in just a few steps. This guide walks you through the most common problems — like declined transactions, activation issues, or Smart Limit errors — and shows how to get your card working again. |
There was a problem hiding this comment.
Restore the opening wrapper or remove its closing tag
Removing the opening <div id="new-expensify" markdown="1"> leaves the existing </div> at the end of this article unmatched. When Jekyll inserts this content inside the layout's article container, that closing tag can close the surrounding layout <div> early, leaving the help and footer markup incorrectly nested; keep the wrapper paired or remove both tags.
Useful? React with 👍 / 👎.
| - Filtering by **Bank account** keeps **Download statement** available. Each settlement is withdrawn from a single bank account, so this filter keeps or removes whole settlements rather than narrowing the transactions inside one. This is useful for isolating an Expensify Card program that settles to its own bank account. | ||
| - With no workspace filter applied, the statement covers the entire settlement across every workspace it spans. If you apply a single workspace filter, the statement is scoped to that workspace's transactions only. | ||
|
|
||
| {:width="100%"} |
There was a problem hiding this comment.
Use a screenshot of the documented reconciliation view
The linked image shows the older Spend > Card statements screen with Feed: Expensify Card and Posted: Last Statement filters and rows grouped by card. It does not show the Reconciliation > Expensify Card view, a Withdrawn date-range filter, or settlement-withdrawal rows described by this article and its alt text, so readers cannot map the screenshot to any of the surrounding instructions.
Useful? React with 👍 / 👎.
|
|
||
| **Note:** The **Status** column is hidden on narrow and medium screens. Widen your browser window or view the list on a larger screen to see it. | ||
|
|
||
| {:width="100%"} |
There was a problem hiding this comment.
Align the status screenshot and alternative text
The referenced image contains only plain Active and Inactive values, while this alternative text says that it shows badges for Pending order, Shipped, Active, and Inactive. Screen-reader users receive an inaccurate description, and sighted readers cannot see examples of half the statuses the image is intended to illustrate; update the asset or describe only what it actually shows.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR adds four screenshots to three existing Expensify Card articles (Set Up and Manage, Troubleshoot, and View and Reconcile) and removes an opening new-expensify wrapper div from the Troubleshoot article. The changes are small and purposeful: the images illustrate the Status column, CSV export, admin settlement/limit page, and the reconciliation withdrawal view, all genuinely visual states that meet the Screenshot Decision Criteria in HELP_AUTHORING_GUIDELINES.md Section 8. Scoring reflects only the added/modified lines in the diff. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review; the div and parenthesis items above are the specific line-level details. |
|
A preview of your ExpensifyHelp changes have been deployed to https://a72f5380.helpdot.pages.dev ⚡️ Updated articles: |
|
@VictoriaExpensify looks like this was merged without a test passing. These checks had not passed on a31bbb3 when it was merged:
Please add a note explaining why this was done and remove the |
|
Failed check was just the review checklist, but this PR is just helpdot, and it was approved by an employee. Removing emergency label |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Adds the first set of images for https://github.com/Expensify/Expensify/issues/665767