Skip to content

[No QA] Fix monthly NextStepUtils test determinism - #100205

Merged
Beamanator merged 3 commits into
mainfrom
codex/100134-fix-monthly-next-step-test
Sep 2, 2026
Merged

[No QA] Fix monthly NextStepUtils test determinism#100205
Beamanator merged 3 commits into
mainfrom
codex/100134-fix-monthly-next-step-test

Conversation

@blimpich

@blimpich blimpich commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The monthly-on-the-2nd test derived its expected date from DateUtils.getNextNthOfMonth, while production uses a different boundary rule. As a result, the test failed whenever CI ran on the 2nd of the month.

The test now pins the system clock and explicitly verifies the monthly ETA before, on, and after the 2nd. Production code is unchanged.

Fixed Issues

$ #100134
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

No production code changes, so offline behavior is unchanged.

QA Steps

Not applicable; this is a test-only change. The PR title includes [No QA].

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors
  • I followed proper code patterns
  • I followed the guidelines stated in the Review Guidelines
  • I tested other components that can be impacted by my changes
  • I added unit tests for this bug fix

Screenshots/Videos

No UI changes.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@blimpich
blimpich marked this pull request as ready for review September 2, 2026 17:37
@blimpich
blimpich requested a review from a team as a code owner September 2, 2026 17:37
@melvin-bot
melvin-bot Bot requested review from ahmedGaber93 and removed request for a team September 2, 2026 17:37
@melvin-bot

melvin-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T17:46:03.116449Z 43f047f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@blimpich

blimpich commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@ahmedGaber93 please ignore the ping

@blimpich
blimpich removed the request for review from ahmedGaber93 September 2, 2026 17:38
@Beamanator
Beamanator merged commit 236168d into main Sep 2, 2026
32 of 33 checks passed
@Beamanator
Beamanator deleted the codex/100134-fix-monthly-next-step-test branch September 2, 2026 17:42
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants