[No QA] Fix monthly NextStepUtils test determinism - #100205
Merged
Merged
Conversation
40 tasks
blimpich
marked this pull request as ready for review
September 2, 2026 17:37
melvin-bot
Bot
requested review from
ahmedGaber93
and removed request for
a team
September 2, 2026 17:37
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@ahmedGaber93 please ignore the ping |
Beamanator
approved these changes
Sep 2, 2026
This was referenced Sep 2, 2026
Merged
35 tasks
35 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.69-0 🚀
|
This was referenced Sep 2, 2026
43 tasks
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The monthly-on-the-2nd test derived its expected date from
DateUtils.getNextNthOfMonth, while production uses a different boundary rule. As a result, the test failed whenever CI ran on the 2nd of the month.The test now pins the system clock and explicitly verifies the monthly ETA before, on, and after the 2nd. Production code is unchanged.
Fixed Issues
$ #100134
PROPOSAL:
Tests
Offline tests
No production code changes, so offline behavior is unchanged.
QA Steps
Not applicable; this is a test-only change. The PR title includes
[No QA].PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
No UI changes.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari