Docs updates for E/A#99025 move travel billing settlements toggle to export page - #100341
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#99025 move travel billing settlements toggle to export page#100341MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
… page Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #99025, which moved Sync Consolidated Travel Billing settlements and the Reconciliation account row out of Advanced and onto the Consolidated Travel Billing page under Export, and locked the toggle until a payable account is set.
Four help articles still told admins to look for that toggle on the Advanced page, so anyone following them would not find it. This updates all four:
Configure-Quickbooks-Online.md— documents the toggle under Step 2: Configure Export Settings and notes on the Advanced step that it is no longer there.Configure-Xero.md— same move, using the Xero label Travel payable account.Configure-Netsuite.md— same move. Also renames the Export row from Export Expensify Travel Payable To to Consolidated Travel Billing, which is what the row is actually labelled, and adds the Journal posting preference row that sits on that page.Configure-Sage-Intacct.md— moves## How to sync Consolidated Travel Billing settlements in Sage Intacctfrom Step 4: Configure Advanced Settings up under Step 3: Configure Export Settings.Each article now also documents the new lock behaviour: the toggle stays locked until the payable/credit card account is selected and Auto-sync is enabled, and turning it on opens the reconciliation account picker before the toggle switches on.
Configure-QuickBooks-Desktop.mdandConfigure-Rillet.mdwere checked and left alone — QuickBooks Desktop only states which connections support the setting (still accurate), and Rillet keeps its own toggle on its Advanced page.Verification notes: the labels above were verified against
src/languages/en.tsand the connection pages onmain. Live UI verification of the Consolidated Travel Billing page was not possible — every one of these four connections needs real third-party OAuth credentials or a Control-plan upgrade to reach the connection card, so the page cannot be opened in a test account.AI tests run:
npm run spell-changed— passed (4 files checked, 0 issues). No other tests in the matrix apply to a docs-only markdown change; docs routing and config were not touched.Fixed Issues
$ #91505
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Docs-only change; likely "[No QA]".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.