[No QA] Move Consolidated Travel Billing settlements to the export page - #99025
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Screen.Recording.2026-08-27.at.15.12.23.movLooks good, but I think when you enable the toggle and click on the back arrow, the toggle shouldn't be turned on if you dont select a bank account? I dont remember exactly what we agreed on. |
|
@allgandalf any update here? |
|
I was OoO yesterday sorry, will get to this today |
|
yeah nothing was agreed on that one. fixed, the toggle now turns on only after you pick an account, backing out leaves it off. |
|
I fixed the broken test on main. You can merge in the latest main or wait till tomorrow and re-run the test. The test was only breaking when it's the 2nd of the month 🤦 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.70-0 🚀
|
|
Yes — help site changes were required. Four articles told admins the Sync Consolidated Travel Billing settlements toggle lives on the Advanced page, which is no longer true after this PR. Draft PR: #100341 What was stale
What the docs PR changes
Checked and deliberately left alone
How labels were verifiedI could not verify against the live UI. All four connections need real third-party OAuth credentials or a Control-plan upgrade before the connection card opens, so the Consolidated Travel Billing page is not reachable in a test account. A web test run confirmed the Accounting row and the connection names, then the QuickBooks Online Connect button redirected off-app to a real OAuth URL and ended the session. Labels were instead verified against
Please confirm these read correctly against what you saw while building the PR.
@allgandalf, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.72-0 🚀
|
Explanation of Change
Sync Consolidated Travel Billing settlementssat on the Advanced page, but the payable account it needs is set on Export > Consolidated Travel Billing. So an admin could turn the toggle on with no account picked, and the sync then failed withConsolidated Travel Billing payable account is not configured. Moved the toggle and theReconciliation accountrow onto the Consolidated Travel Billing page, and locked the toggle until the payable account is set. Xero, Sage Intacct and NetSuite had the same split, so they all move.Fixed Issues
$ #91505
PROPOSAL:
Tests
./script/clitools.sh expensifytravel:setupInvoicing --enable)Sync Consolidated Travel Billing settlementsis no longer thereCredit card account, locked, and its tooltip says to set an account for your exportsReconciliation accountrow below the toggleOffline tests
Offline, toggle the row and pick a reconciliation account. Both show pending styling and settle when the network is back.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari