Skip to content

[No QA] Move Consolidated Travel Billing settlements to the export page - #99025

Merged
blimpich merged 8 commits into
Expensify:mainfrom
allgandalf:move-travel-settlements-to-export
Sep 3, 2026
Merged

[No QA] Move Consolidated Travel Billing settlements to the export page#99025
blimpich merged 8 commits into
Expensify:mainfrom
allgandalf:move-travel-settlements-to-export

Conversation

@allgandalf

Copy link
Copy Markdown
Contributor

Explanation of Change

Sync Consolidated Travel Billing settlements sat on the Advanced page, but the payable account it needs is set on Export > Consolidated Travel Billing. So an admin could turn the toggle on with no account picked, and the sync then failed with Consolidated Travel Billing payable account is not configured. Moved the toggle and the Reconciliation account row onto the Consolidated Travel Billing page, and locked the toggle until the payable account is set. Xero, Sage Intacct and NetSuite had the same split, so they all move.

Fixed Issues

$ #91505
PROPOSAL:

Tests

  1. Enable Consolidated Travel Billing on a workspace (./script/clitools.sh expensifytravel:setupInvoicing --enable)
  2. Connect QuickBooks Online and turn Auto-sync on
  3. Open Workspace > Accounting > Advanced. Verify Sync Consolidated Travel Billing settlements is no longer there
  4. Open Workspace > Accounting > Export > Consolidated Travel Billing. Verify the toggle is now here, below Credit card account, locked, and its tooltip says to set an account for your exports
  5. Pick a credit card account. Verify the toggle unlocks
  6. Turn it on. Verify it opens the reconciliation account picker, and the account you pick shows in a Reconciliation account row below the toggle
  7. Turn Auto-sync off. Verify the toggle locks again and its tooltip now says to enable auto-sync
  8. Repeat on Xero, Sage Intacct and NetSuite
  • Verify that no errors appear in the JS console

Offline tests

Offline, toggle the row and pick a reconciliation account. Both show pending styling and settle when the network is back.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

@allgandalf
allgandalf marked this pull request as ready for review August 27, 2026 12:28
@allgandalf
allgandalf requested review from a team as code owners August 27, 2026 12:28
@melvin-bot
melvin-bot Bot requested review from huult and removed request for a team August 27, 2026 12:29
@melvin-bot

melvin-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team August 27, 2026 12:29
@rlinoz

rlinoz commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-27.at.15.12.23.mov

Looks good, but I think when you enable the toggle and click on the back arrow, the toggle shouldn't be turned on if you dont select a bank account? I dont remember exactly what we agreed on.

@blimpich

Copy link
Copy Markdown
Contributor

@allgandalf any update here?

@allgandalf

Copy link
Copy Markdown
Contributor Author

I was OoO yesterday sorry, will get to this today

@allgandalf

Copy link
Copy Markdown
Contributor Author

yeah nothing was agreed on that one. fixed, the toggle now turns on only after you pick an account, backing out leaves it off.

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blimpich

blimpich commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I fixed the broken test on main. You can merge in the latest main or wait till tomorrow and re-run the test. The test was only breaking when it's the 2nd of the month 🤦

@blimpich

blimpich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@blimpich
blimpich merged commit 6c3f4fe into Expensify:main Sep 3, 2026
41 of 45 checks passed
@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.70-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Yes — help site changes were required. Four articles told admins the Sync Consolidated Travel Billing settlements toggle lives on the Advanced page, which is no longer true after this PR.

Draft PR: #100341

What was stale

Article Was
docs/articles/new-expensify/connections/quickbooks-online/Configure-Quickbooks-Online.md Toggle documented under Step 3: Configure Advanced Settings
docs/articles/new-expensify/connections/xero/Configure-Xero.md Toggle documented under Step 3: Configure Advanced Settings
docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md Toggle documented under Step 3: Configure Advanced Settings
docs/articles/new-expensify/connections/sage-intacct/Configure-Sage-Intacct.md ## How to sync Consolidated Travel Billing settlements in Sage Intacct sat under Step 4: Configure Advanced Settings

What the docs PR changes

  • Moves the toggle into each article's Export step, on the Consolidated Travel Billing page below the payable/credit card account row.
  • Documents the new lock behavior: the toggle stays locked until the account is set and Auto-sync is enabled, and turning it on opens the reconciliation account picker first, after which the account appears in a Reconciliation account row.
  • NetSuite only: also renames the Export row from Export Expensify Travel Payable To to Consolidated Travel Billing (the actual label), and adds the Journal posting preference row that sits on that page.
Checked and deliberately left alone
  • Configure-QuickBooks-Desktop.md — only states the setting is available for QuickBooks Online, Xero, NetSuite, and Sage Intacct. Still accurate.
  • Configure-Rillet.md — Rillet was not touched by this PR and keeps its own toggle on its Advanced page.
How labels were verified

I could not verify against the live UI. All four connections need real third-party OAuth credentials or a Control-plan upgrade before the connection card opens, so the Consolidated Travel Billing page is not reachable in a test account. A web test run confirmed the Accounting row and the connection names, then the QuickBooks Online Connect button redirected off-app to a real OAuth URL and ended the session.

Labels were instead verified against src/languages/en.ts and the connection pages on main, which are the source of those UI strings:

  • syncTravelInvoicingSettlementsSync Consolidated Travel Billing settlements
  • reconciliationAccountReconciliation account
  • workspace.common.travelInvoicingConsolidated Travel Billing (the page header)
  • travelInvoicingPayableAccountTravel payable account (Xero)
  • nonReimbursableJournalPostingAccount (NetSuite), creditCardAccount (QuickBooks Online, Sage Intacct)

Please confirm these read correctly against what you saw while building the PR.

npm run spell-changed passed on all four files. No other tests in the selection matrix apply to a docs-only markdown change.


@allgandalf, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.72-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants