Skip to content

[NoQA] Add missing prop to fix typecheck in test #68406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 2 commits into from
Aug 12, 2025
Merged

[NoQA] Add missing prop to fix typecheck in test #68406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a9473
Add missing prop to fix ESLint in test
francoisl Aug 12, 2025
cbb8eac
Fix `@typescript-eslint/no-unnecessary-type-assertion` error
francoisl Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ function MoneyRequestReportView({report, policy, reportMetadata, shouldDisplayRe
if (isTransactionThreadView) {
// Extract transaction ID from parent report action to get specific violations
const transactionID = getTransactionIDFromReportAction(parentReportAction);
const transactionViolations = transactionID && reportViolations ? (reportViolations as Record<string, OnyxTypes.TransactionViolations>)[transactionID] : undefined;
const transactionViolations = transactionID && reportViolations ? reportViolations[transactionID] : undefined;

return (
<MoneyRequestHeader
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/ReportScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) {

if (isTransactionThreadView) {
const transactionID = getTransactionIDFromReportAction(parentReportAction);
const transactionViolations = transactionID && allReportViolations ? (allReportViolations as Record<string, OnyxTypes.TransactionViolations>)[transactionID] : undefined;
const transactionViolations = transactionID && allReportViolations ? allReportViolations[transactionID] : undefined;
Copy link
Copy Markdown
Contributor Author

@francoisl francoisl Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes https://github.com/Expensify/App/actions/runs/16919414682/job/47941472731 which was introduced in #67065.

cc @roryabraham I think that's why you got pinged in https://expensify.slack.com/archives/C01GTK53T8Q/p1755023194590859


headerView = (
<MoneyRequestHeader
Expand Down
1 change: 1 addition & 0 deletions tests/actions/IOUTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6716,6 +6716,7 @@ describe('actions/IOU', () => {
merchant: 'NASDAQ',
comment: '*hey* `hey`',
},
shouldGenerateTransactionThreadReport: true,
});
await waitForBatchedUpdates();
await getOnyxData({
Expand Down
Loading