Add share option to saved searches overflow menu by aswin-s · Pull Request #88768 · Expensify/App

aswin-s · 2026-04-25T03:37:34Z

Explanation of Change

Adds a Share option to the saved searches overflow menu (both in the wide layout SavedSearchList and narrow layout SearchTypeMenuNarrow). Tapping Share copies the search URL to the clipboard and briefly shows a "URL copied" confirmation with a checkmark icon for 1.8 seconds. The menu stays open during the feedback so the user can see the confirmation.

Fixed Issues

$ #87627
PROPOSAL: #87627 (comment)

Tests

Open the app and save a search
Long-press (narrow) or open the three-dot menu (wide) on a saved search
Tap Share
Verify the menu stays open and the item changes to show a checkmark and "URL copied"
After ~1.8 seconds, verify the item reverts to the share icon and label
Paste from clipboard and verify the URL navigates to the correct saved search

Verify that no errors appear in the JS console

Offline tests

The share action only copies a URL to the clipboard — no network requests are made. Behavior is identical offline.

QA Steps

Same as tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

88768-android-native.mp4

Android: mWeb Chrome

88768-android-web.mp4

iOS: Native

8878-ios-native.mp4

iOS: mWeb Safari

8878-ios-web.mp4

MacOS: Chrome / Safari

88768-MacOS.mp4

melvin-bot · 2026-04-25T03:37:39Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-04-25T03:49:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useShareSavedSearch.ts	`100.00% <100.00%> (ø)`
src/components/ThreeDotsMenu/index.tsx	`85.93% <0.00%> (ø)`
src/libs/SearchUIUtils.ts	`63.72% <0.00%> (-0.12%)`	⬇️
src/pages/Search/SearchTypeMenuNarrow.tsx	`74.68% <33.33%> (-2.65%)`	⬇️
src/pages/Search/SavedSearchList.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SavedSearchItemThreeDotMenu.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

melvin-bot · 2026-04-27T09:19:14Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2026-05-01T05:30:07Z

I will review this today. I was OOO, sorry for the delay.

jayeshmangwani · 2026-05-03T05:07:52Z

@aswin-s I initially faced a crash when opening the Spend tab. I suspect the change from import React from 'react'; to import type React from 'react'; in src/pages/Search/SavedSearchList.tsx may be causing it.

jayeshmangwani · 2026-05-03T05:12:51Z

The URL copied text doesn’t look good, I think it has the same color as the Share text. Tagging @shawnborton to get their consensus.

Share text

aswin-s · 2026-05-03T16:28:49Z

@jayeshmangwani Good catch! The confirmation state now matches the Context Menu → Copy Link pattern for consistency.

Context Menu:

Saved Search:

@shawnborton Quick question: should we add an exclamation mark after "Copied" to match the context menu's "Copied!" text?

shawnborton · 2026-05-03T18:28:07Z

Yeah, that makes sense to me. cc @Expensify/marketing for viz on that but let's do it!

shawnborton · 2026-05-03T18:28:50Z

And yes, I agree we want the styles/colors to exactly match what we have for the Copy text action.

jayeshmangwani · 2026-05-03T19:51:17Z

@aswin-s, checkbox icon should be green.

Also, I think that once the Share button is pressed and ‘URL copied’ appears, the modal should close automatically after ~2 seconds.

aswin-s · 2026-05-04T08:36:40Z

@jayeshmangwani I've updated the implementation to replicate the ContextMenu behaviour for consistency
with the existing pattern. That said, worth calling out two things:

The menu closes ~800ms after clicking copy link — this matches the shouldDelay timing used in
hideContextMenu for the ContextMenu's copy link action.
The checkmark appears in grey/disabled color — this is actually consistent with the existing
ContextMenu pattern, where the ContextMenuItem renders the icon in the default color during the success
state (because interactive={false} short-circuits getButtonState to DEFAULT before reaching COMPLETE).

So the green checkmark shown in the issue video is not how the existing ContextMenu pattern works.
Should we keep it consistent with the current ContextMenu behaviour (grey), or intentionally deviate
and make it green as shown in the issue?

aswin-s · 2026-05-04T08:37:34Z

Also looks like typecheck is failing on main branch. It is unrelated to our changes.

jayeshmangwani · 2026-05-05T05:33:43Z

@aswin-s Can we also close the modal on mobile devices? Also, can we merge main to check if the failing test is resolved?

mobile-bug.mov

jayeshmangwani · 2026-05-05T05:34:19Z

Can we update the cursor to show the normal pointer instead of "not-allowed", similar to how it works for message copy on the report page?

aswin-s · 2026-05-05T13:59:24Z

@jayeshmangwani Fixed the native experience as well and updated the videos for all devices in OP. Rebased with main but the fix for typescript lint has not landed yet.

jayeshmangwani · 2026-05-07T11:12:22Z

@aswin-s Types are failing only on our PR because we’re passing personalPolicyID={undefined} in tests/ui/PureReportActionItemTest.tsx, but the personalPolicyID prop was removed in this PR #89160.

- Remove useCallback from useShareSavedSearch hook (React Compiler handles memoization) - Move shouldCloseModalOnSelect check into PopoverMenu to avoid duplication - Remove redundant guards from ThreeDotsMenu and SearchTypeMenuNarrow callers

… state Matches context menu copy pattern: grey checkmark icon with black label text.

…u behaviour

… saved searches

…e menu close logic

…med-export rule

…and guard ThreeDotsMenu hide Restores the onItemSelected call in PopoverMenu's shouldCloseModalOnSelect===false branch to preserve generic behaviour for all callers (e.g. ButtonWithDropdownMenu). Guards ThreeDotsMenu.hidePopoverMenu against shouldCloseModalOnSelect===false so the menu stays open for items like Copy Link, matching the existing shouldKeepModalOpen pattern.

…election Guard onItemSelected in SearchTypeMenuNarrow to not close the popover when shouldCloseModalOnSelect is false, matching the same pattern used in ButtonWithDropdownMenu and ThreeDotsMenu.

aswin-s · 2026-05-07T12:21:45Z

@jayeshmangwani Fixed everything and rebased with main.

jayeshmangwani · 2026-05-07T16:02:43Z

@aswin-s , everything looks good to me. Could you please add the Slack link for the translation confirmation?

aswin-s · 2026-05-09T07:43:30Z

@jayeshmangwani Added translation request here. Yet to get a confirmation.
https://expensify.slack.com/archives/C01GTK53T8Q/p1778179785608289

aswin-s · 2026-05-11T19:44:44Z

@jayeshmangwani Re-requested the translation and it is approved.

https://expensify.slack.com/archives/C01GTK53T8Q/p1778527194871009

jayeshmangwani · 2026-05-12T12:13:55Z

Thanks for confirming the translation.

jayeshmangwani

LGTM 🚀

OSBotify · 2026-05-12T17:45:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-12T18:10:36Z

🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-12T18:39:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88768.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-274006b-1ff9b8a-9ab05e78b049b3629139b7e08cb7a3d47467ae4e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-274006b-1ff9b8a-63dbe8928154324d88a153d12c1952913b1eaecd/index.html

Web 🕸️
https://88768.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-13T07:23:25Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-05-13T07:28:17Z

Yes, the help site needs a minor update. The article Using-Reports-in-New-Expensify.md describes saved search management actions (rename, delete) but doesn't mention the new Share option.

I've created a draft PR with the update: #90427

Changes made:

Updated the saved search management sentence to include "share" alongside rename and delete, and added a note that Share copies the search URL to the clipboard
Added "share saved search" to article keywords for discoverability

OSBotify · 2026-05-13T07:54:24Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-13T20:56:29Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned aswin-s Apr 25, 2026

aswin-s force-pushed the feat/add-share-option-to-saved-searches branch from ee0bd6c to dda5591 Compare April 25, 2026 03:41

aswin-s marked this pull request as ready for review April 27, 2026 09:19

aswin-s requested review from a team as code owners April 27, 2026 09:19

melvin-bot Bot requested review from JmillsExpensify and jayeshmangwani and removed request for a team and jayeshmangwani April 27, 2026 09:19

aswin-s force-pushed the feat/add-share-option-to-saved-searches branch 2 times, most recently from 50d0704 to 0429426 Compare April 28, 2026 23:35

aswin-s force-pushed the feat/add-share-option-to-saved-searches branch from 970903e to 7efb7e8 Compare May 4, 2026 08:30

aswin-s force-pushed the feat/add-share-option-to-saved-searches branch from bc8af4d to 94750ff Compare May 5, 2026 07:44

aswin-s added 8 commits May 7, 2026 17:08

fix: remove unnecessary type import for React in SavedSearchList

05435ff

fix: remove disabled property from overflow menu shareProps

8f240e8

fix: use disabled with shouldGreyOutWhenDisabled false for URL copied…

3ce5ef3

… state Matches context menu copy pattern: grey checkmark icon with black label text.

fix: auto-close saved search menu after copy link to match ContextMen…

3b308bc

…u behaviour

fix: use default cursor and auto-close mobile menu after copy link in…

10276a4

… saved searches

refactor: extract MENU_CLOSE_DELAY_MS to shared hook and inline mobil…

36ff97c

…e menu close logic

fix: use named export for MENU_CLOSE_DELAY_MS to satisfy no-inline-na…

9eb891f

…med-export rule

aswin-s force-pushed the feat/add-share-option-to-saved-searches branch from 00d5a20 to 9eb891f Compare May 7, 2026 11:38

aswin-s added 2 commits May 7, 2026 17:25

fix: prevent mobile web popover from closing instantly on Copy Link s…

bafcd27

…election Guard onItemSelected in SearchTypeMenuNarrow to not close the popover when shouldCloseModalOnSelect is false, matching the same pattern used in ButtonWithDropdownMenu and ThreeDotsMenu.

jayeshmangwani approved these changes May 12, 2026

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify May 12, 2026 12:14

aldo-expensify approved these changes May 12, 2026

View reviewed changes

aldo-expensify merged commit 274006b into Expensify:main May 12, 2026
39 checks passed

OSBotify mentioned this pull request May 13, 2026

Deploy Checklist: New Expensify 2026-05-13 #90410

Closed

82 tasks

MelvinBot mentioned this pull request May 13, 2026

[No QA] Docs updates for E/A#88768 Add share option to saved searches docs #90427

Open

melvin-bot Bot mentioned this pull request May 13, 2026

[Due for payment 2026-05-20] [$250] Add share option to saved searches #87627

Open

Conversation

aswin-s commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 25, 2026

Uh oh!

codecov Bot commented Apr 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

jayeshmangwani commented May 3, 2026

Uh oh!

jayeshmangwani commented May 3, 2026

Uh oh!

aswin-s commented May 3, 2026

Uh oh!

shawnborton commented May 3, 2026

Uh oh!

shawnborton commented May 3, 2026

Uh oh!

jayeshmangwani commented May 3, 2026

Uh oh!

aswin-s commented May 4, 2026

Uh oh!

aswin-s commented May 4, 2026

Uh oh!

jayeshmangwani commented May 5, 2026

Uh oh!

jayeshmangwani commented May 5, 2026

Uh oh!

aswin-s commented May 5, 2026

Uh oh!

jayeshmangwani commented May 7, 2026

Uh oh!

aswin-s commented May 7, 2026

Uh oh!

jayeshmangwani commented May 7, 2026

Uh oh!

aswin-s commented May 9, 2026

Uh oh!

aswin-s commented May 11, 2026

Uh oh!

jayeshmangwani commented May 12, 2026

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

aswin-s commented Apr 25, 2026 •

edited

Loading

codecov Bot commented Apr 25, 2026 •

edited by github-actions Bot

Loading