decompose ReportActionsList: 2 by adhorodyski · Pull Request #89598 · Expensify/App

adhorodyski · 2026-05-05T11:45:44Z

Explanation of Change

PR 2 of the ReportActionsList decomposition series (#88320, blueprint #87506).

Extracts two pipeline hooks from the inline pagination logic in ReportActionsView:

useReportActionsPagination — wraps usePaginatedReportActions, handles optimistic CREATED report action injection, money-request optimistic IOU injection, and getCombinedReportActions thread stitching. Reads RAM_ONLY_REPORT_LOADING_STATE to factor isLoadingInitialReportActions into the optimistic-CREATED gate so behavior matches current main.
useTransactionThread — owns transaction-thread report ID derivation (via getOneTransactionThreadReportID + non-deleted transaction filtering), thread report actions selector, and parent action lookup.

ReportActionsView shrinks from 377 → ~232 lines by replacing the inline block with a single useReportActionsPagination(reportID) call. Skeleton flags, concierge filtering, list ID, layout, and the visibleReportActions post-filter all stay in the View.

useLoadReportActions signature simplified: transactionThreadReport: OnyxEntry<Report> → transactionThreadReportID: string | undefined. Removes the dependency on the full Onyx report entry — only the ID is ever read inside the hook. Updated call sites in ReportActionsView and MoneyRequestReportView/MoneyRequestReportActionsList.

useTransactionsAndViolationsForReport exposes a new isLoaded field (additive, no breaking changes for existing consumers).

ReportActionsList.tsx is unchanged — it still receives data via props from ReportActionsView. List moves to direct hook calls in PR 6 with the orchestrator swap.

Fixed Issues

$ #88320
PROPOSAL:

Tests

Open a regular chat — messages render, pagination works (scroll up loads older, new arrivals load newer)
Open a money-request / invoice report — optimistic CREATED action shows, totals display correctly
Open a transaction thread report — thread actions merge into the list in correct order
Deep-link into a specific message — list anchors to the linked action
Open Concierge in side panel — optimistic CREATED + greeting render correctly
Verify no console errors / warnings

Offline tests

Same as Tests, run with airplane mode toggled mid-session.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-05-05T11:54:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx	`65.56% <100.00%> (+0.39%)`	⬆️
src/hooks/useReportActionsPagination.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/report/ReportActionsView.tsx	`92.68% <100.00%> (-1.71%)`	⬇️
src/hooks/useLoadReportActions.ts	`86.84% <66.66%> (ø)`
src/hooks/useTransactionThread.ts	`94.73% <94.73%> (ø)`
... and 314 files with indirect coverage changes

…gination-hooks

adhorodyski · 2026-05-06T08:46:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7216bf17c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

adhorodyski · 2026-05-06T09:25:19Z

@codex review

chatgpt-codex-connector · 2026-05-06T09:32:11Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-05-06T10:29:02Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9dae3f470

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…gination-hooks

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…tps://github.com/callstack-internal/Expensify-App into refactor/extract-report-actions-pagination-hooks

DylanDylann · 2026-05-14T07:47:05Z

@codex review

chatgpt-codex-connector · 2026-05-14T07:51:53Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-05-14T07:56:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-14.at.15.03.19.mov

Android: mWeb Chrome

Screen.Recording.2026-05-14.at.15.00.07.mov

iOS: HybridApp

Screen.Recording.2026-05-14.at.15.04.42.mov

iOS: mWeb Safari

Screen.Recording.2026-05-14.at.14.59.36.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-14.at.14.59.03.mov

rlinoz

Thanks!

github-actions · 2026-05-15T11:49:01Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-15T11:53:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89598.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-122081b-1898b9d-988f03df6ae3faa3250326d277a6fb86f80f2c6c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-122081b-1898b9d-aec4e27cdfa1fac63828d75c0516b96ac6f9246d/index.html

Web 🕸️
https://89598.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-15T11:57:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-15T17:23:30Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-15T17:25:36Z

This PR is a purely internal refactoring — it extracts two React hooks (useReportActionsPagination and useTransactionThread) from ReportActionsView and simplifies a type signature in useLoadReportActions. There are no user-facing behavior changes, no new features, no UI changes, and no terminology updates.

No changes are required to Expensify's help site files.

OSBotify · 2026-05-15T18:08:49Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-05-15T20:37:28Z

Hi @adhorodyski. QA steps are not very clear.
Could you please update them with more detailed instructions?

cc @rlinoz @JmillsExpensify @DylanDylann

rlinoz · 2026-05-16T15:16:18Z

@IuliiaHerets I think you can follow this one:

Open a chat chat

Verify messages are displayed correctly
Verify you can scroll up and down and the other messages are also displayed
Verify when you receive a new message in the open chat, they also get displayed

Open a money-request / invoice report

Verify you can see the fields of the money request/invoice and they are correct, like totals

Others

Open a transaction thread report and verify the messages are displayed correctly
Deep-link into a specific message and verify you are taken to the correct message
Open Concierge in side panel and verify greeting render correctly

decompose ReportActionsList: 2

44bbe9c

melvin-bot Bot assigned adhorodyski May 5, 2026

adhorodyski added 3 commits May 5, 2026 21:36

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

6fc3580

…gination-hooks

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

d51c006

…gination-hooks

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

a7216bf

…gination-hooks

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

Comment thread src/hooks/useLoadReportActions.ts Outdated

Comment thread src/hooks/useReportActionsPagination.ts Outdated

Exclude FAKE_REPORT_ID from thread pagination guard

e9dae3f

adhorodyski marked this pull request as ready for review May 6, 2026 10:28

adhorodyski requested review from a team as code owners May 6, 2026 10:28

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team May 6, 2026 10:29

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

Comment thread src/hooks/useReportActionsPagination.ts Outdated

adhorodyski and others added 4 commits May 6, 2026 22:01

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

a53377e

…gination-hooks

lint: drop unused prefer-nullish-coalescing disable

3ee002d

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

26c12df

…gination-hooks

fix import: getReportPreviewAction now lives in MoneyRequestBuilder

ce346cf

DylanDylann reviewed May 7, 2026

View reviewed changes

Comment thread src/hooks/useLoadReportActions.ts

Comment thread jest.config.js Outdated

Comment thread src/hooks/useTransactionsAndViolationsForReport.ts Outdated

Comment thread src/hooks/useReportActionsPagination.ts Outdated

Comment thread src/hooks/useReportActionsPagination.ts Outdated

adhorodyski and others added 4 commits May 11, 2026 12:10

Merge branch 'Expensify:main' into refactor/extract-report-actions-pa…

2b851f1

…gination-hooks

address PR feedback: drop unused isLoaded, revert .claude jest ignore

d1d830a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Merge branch 'refactor/extract-report-actions-pagination-hooks' of ht…

79ee4c1

…tps://github.com/callstack-internal/Expensify-App into refactor/extract-report-actions-pagination-hooks

Merge exfy/main

0d5709e

adhorodyski requested a review from DylanDylann May 13, 2026 13:05

DylanDylann reviewed May 14, 2026

View reviewed changes

Comment thread src/hooks/useTransactionThread.ts Outdated

address PR feedback: drop useCallback wrapper in useTransactionThread

6fd8bc2

adhorodyski requested a review from DylanDylann May 14, 2026 11:14

DylanDylann approved these changes May 15, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz May 15, 2026 02:43

rlinoz approved these changes May 15, 2026

View reviewed changes

rlinoz merged commit 122081b into Expensify:main May 15, 2026
38 checks passed

adhorodyski deleted the refactor/extract-report-actions-pagination-hooks branch May 15, 2026 11:59

OSBotify mentioned this pull request May 15, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

melvin-bot Bot mentioned this pull request May 15, 2026

Decompose ReportActionsList #88320

Open

This was referenced May 19, 2026

decompose ReportActionsList: 3 #91048

Merged

decompose ReportActionsList: 4 #91179

Draft

DylanDylann mentioned this pull request May 26, 2026

[Due for payment 2026-05-22][Split #88320] PR 2 - Extract data hooks #89763

Closed

MelvinBot mentioned this pull request May 28, 2026

Revert "Merge pull request #90072 from margelo/@chrispader/open-reports-at-last-unread-action-v2" #91949

Draft

51 tasks

Conversation

adhorodyski commented May 5, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adhorodyski commented May 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

adhorodyski commented May 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 6, 2026

Uh oh!

melvin-bot Bot commented May 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 14, 2026

Uh oh!

Uh oh!

DylanDylann commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

IuliiaHerets commented May 15, 2026

Uh oh!

rlinoz commented May 16, 2026

Open a chat chat

Open a money-request / invoice report

Others

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented May 5, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented May 14, 2026 •

edited

Loading