decompose ReportActionsList: 3#91048
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71c2e57539
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@codex review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-20.at.11.22.36.movAndroid: mWeb ChromeScreen.Recording.2026-05-20.at.11.13.44.moviOS: HybridAppScreen.Recording.2026-05-20.at.11.23.21.moviOS: mWeb SafariScreen.Recording.2026-05-20.at.11.14.36.movMacOS: Chrome / SafariScreen.Recording.2026-05-20.at.11.10.51.mov |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is an internal code refactoring (part 3 of the ReportActionsList decomposition series) that moves session/concierge filtering logic from |
|
Hi @adhorodyski. Can you please share more detailed QA steps for this PR?
|
|
Hey @IuliiaHerets you can follow this ones:
Let me know if this is not clear! |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|

Explanation of Change
PR 3 of the ReportActionsList decomposition series (tracker: #88320, blueprint: #87506). PR 1 (#88392) and PR 2 (#89598) already merged.
Extracts session/concierge filtering and "Show full history" toggle out of
ReportActionsView.tsxinto a newsrc/hooks/useReportActionsVisibility.ts(~89 LOC). The inline filter logic and theuseConciergeSidePanelReportActionscall site inReportActionsVieware replaced by a single hook call.Deviations from blueprint:
{visibleReportActions, hasPreviousMessages, showFullHistory, handleShowPreviousMessages}. Four additional fields are returned (sortedReportActions,sortedVisibleReportActions,isConciergeSidePanel,showConciergeSidePanelWelcome) becauseReportActionsViewstill owns skeleton branching and passes both sorted/visible lists as props to children. PR6 will trim the hook to blueprint shape when View is removed.Fixed Issues
$ #89764
Tests
Offline tests
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avatar, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari