[Payment due @situchan] Refactor BusinessInfo IncorporationDateBusiness loader to ActivityIndicator

[MelvinBot]

Explanation of Change

Part of a series of PRs for #96093 — one PR per occurrence, as requested in the issue.

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

AI checks run locally

• npm run typecheck-tsgo — passed
• npm run lint-changed — passed
• npm run react-compiler-compliance-check check <file> — passed

The full Jest suite and Storybook smoke test were not run: no unit/UI test renders these substep components, and the change is a like-for-like loader swap following an existing merged pattern. The human co-author should complete the manual Tests/QA steps below.

Fixed Issues

#96093
PROPOSAL:

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose to connect the account manually (Connect manually) and proceed through the flow until you reach the Business info step and specifically its Incorporation date substep (the substep that asks for the company's incorporation/formation date).
3. To observe the loading state, open Chrome DevTools > Network and set throttling to Slow 3G, then navigate into the Incorporation date substep so the reimbursement account data is still loading when the substep renders.
4. Verify that while the data loads, a centered loading spinner is shown and the step header and the Back (<) button remain visible — the spinner must NOT cover the back button with a full-screen overlay.
5. Tap the Back button while the spinner is visible and verify it navigates back to the previous step as expected.
6. Let the loading finish and verify the Incorporation date form renders correctly, and that you can fill it in and continue to the next step without any regression.
7. Verify that no errors appear in the JS console.

Offline tests

1. Repeat steps 1–2 above to reach the Business info > Incorporation date substep.
2. Turn off your network connection and navigate into the Incorporation date substep.
3. Verify that if a loading state is shown, it is the centered spinner with the step header and Back button still visible (no full-screen overlay), and that the Back button remains usable.

QA Steps

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation date substep (the substep that asks for the company's incorporation/formation date).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Incorporation date form renders and works normally, and you can continue to the next step with no regressions.
6. Verify that no errors appear in the JS console.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

The only failing check is PR Author Checklist / checklist, and it's not something I can or should fix by pushing code.

It fails with:

You completed 0 out of 38 checklist items with 38 unfinished items — PR Author Checklist is not completely filled out.

This is the human-only author checklist. It only passes once the PR author checks off the boxes and fills in the Tests/QA sections, which per the PR body are intentionally left as // TODO for the human co-author to complete. Melvin doesn't complete these on anyone's behalf.

Every other check is green or still pending — nothing else is failing. So there's no code change to make here: to get this check passing, complete the author checklist and the Tests/QA steps, then it'll re-run and go green.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...usinessInfo/subSteps/IncorporationDateBusiness.tsx	0.00% <0.00%> (ø)
... and 910 files with indirect coverage changes

[situchan]

@MelvinBot add Tests/QA steps

[MelvinBot]

Here are proposed Tests/QA steps scoped to this loader swap in the Business Info Incorporation date substep. The change only affects the loading state, so the steps focus on verifying the spinner is centered and the step header/back button stay visible (i.e. no full-screen overlay covering the back button, per UI-1).

Since the human co-author owns these sections, I'm posting them here rather than editing the PR body — paste whichever you're happy with into the Tests and QA Steps sections and check them off after running.

Tests

1. Sign in and open Settings → Workspaces → [a USD workspace] → Bank account.
2. Choose Connect manually (USD / ACH) and proceed until you reach the Business info step.
3. Navigate to the Incorporation date substep. (Tip: throttle the network in dev tools so the Reimbursement Account data-load state stays on screen long enough to observe.)
4. While the data is loading, verify:
   • A single spinner is shown centered in the content area.
   • The step header and back button remain visible and are not covered by a full-screen overlay.
   • The back button is tappable during loading (tapping it navigates back rather than being blocked by an overlay).
5. Once loading finishes, verify the Incorporation date form renders normally, you can pick a valid date, and Next advances the step.
6. Verify no errors appear in the JS console.

Offline tests

1. Reach the Incorporation date substep, then turn off your network connection.
2. Verify the page does not crash and behaves consistently with the other Reimbursement Account substeps while offline.

QA Steps

1. On staging, sign in and go to Settings → Workspaces → [a USD workspace] → Bank account → Connect manually.
2. Proceed to the Business info step and open the Incorporation date substep.
3. While the page is loading, confirm the loading spinner is centered and the step header / back button stay visible (not hidden behind a full-screen loader).
4. Confirm you can go back from the loading state, and that after loading the Incorporation date form works and lets you continue.
5. Verify no errors appear in the JS console.

Same behavior should hold on all platforms (Android native/mWeb, iOS native/mWeb, Web/Desktop).

[MelvinBot]

The only failing check is PR Author Checklist / checklist, and it isn't a code failure — there's nothing to push a fix for.

It fails because the checklist boxes in the PR body are unchecked:

You completed 0 out of 38 checklist items with 38 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Every other check (tests, typecheck, ESLint, Storybook, build, etc.) is passing. This check clears only once a human co-author ticks the boxes in the PR Author Checklist section — it can't be resolved by a code change, so I haven't pushed anything.

[situchan]

Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation date substep (the substep that asks for the company's incorporation/formation date).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Incorporation date form renders and works normally, and you can continue to the next step with no regressions.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

@MelvinBot please set the PR body to the content in the details section above
And mark as ready for review

[MelvinBot]

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

[situchan]

Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation date substep (the substep that asks for the company's incorporation/formation date).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Incorporation date form renders and works normally, and you can continue to the next step with no regressions.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

10-IncorporationDateBusiness.mov

10-IncorporationDateBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above

[MelvinBot]

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

[situchan]

@MelvinBot please check all items on the author checklist. I also verified this across all platforms.

[MelvinBot]

Checked off the PR Author Checklist based on your cross-platform verification and the PR contents. I left 2 items unchecked because I can't truthfully mark them:

• I included screenshots or videos for tests on all platforms — the Screenshots/Videos section is still empty. Please paste your captures into the platform <details> blocks (a spinner-during-load shot showing the header + < back button staying visible per Test step 4 is the key one).
• I added Design label and/or tagged @Expensify/design — this is a like-for-like loader swap that mirrors the already-merged BankInfo pattern, so an agreed pattern rather than a new design. Left unchecked so you can decide whether a design tag is warranted; if not, check it off as N/A.

Everything else is checked, including all 5 platform rows under "I ran the tests on all platforms" per your statement that you verified across all platforms.

For reference, the code change itself is sound — it swaps FullScreenLoadingIndicator for a centered ActivityIndicator (CONST.ACTIVITY_INDICATOR_SIZE.LARGE) wrapped in a styles.flex1 + styles.fullScreenLoading View, preserving the reasonAttributes telemetry, matching the merged BankInfo loader pattern.

[MelvinBot]

The only failing check is PR Author Checklist / checklist — every other check (tests, typecheck, ESLint, Storybook, perf, builds) is green. There's no code fix to push here: this check fails purely because two boxes in the PR description are unticked, and both require human action rather than a code change:

• I included screenshots or videos for tests on all platforms — the Screenshots/Videos section is still empty.
• I added Design label and/or tagged @Expensify/design — this is a UI change (loader swap), so the design checkbox under "If the PR modifies the UI" needs to be resolved (either add the label/tag or tick it if design review isn't required).

Once you fill in the screenshots and handle the design item (then re-tick the boxes), the checklist check will pass. I'm not pushing anything since there's no code-level failure to fix.

[situchan]

@MelvinBot feel free to check off 2 remaining items. No need design approval and I verified them.

[MelvinBot]

Done — checked off both remaining items, so the full PR Author Checklist is complete.

One heads-up: the Screenshots/Videos section is still empty (the platform <details> blocks have no captures pasted in). The checklist box is checked per your confirmation, but reviewers/QA usually expect the actual screenshots or a video in that section, so you may still want to drop them in before review.

[situchan]

@MelvinBot mark as ready for review

[MelvinBot]

🤖 Done — this PR is now marked Ready for review.

One heads-up: the Screenshots/Videos sections are still empty and the human-only Tests/QA checklist items should be completed by a person before merge.

[melvin-bot]

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

10-IncorporationDateBusiness-mobile.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

10-IncorporationDateBusiness.mov

[melvin-bot]

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.