Skip to content

[Payment due @situchan] Refactor BusinessInfo AddressBusiness loader to ActivityIndicator - #96829

Merged
mollfpr merged 2 commits into
mainfrom
claude-ra-ai-addressBusiness
Aug 4, 2026
Merged

[Payment due @situchan] Refactor BusinessInfo AddressBusiness loader to ActivityIndicator#96829
mollfpr merged 2 commits into
mainfrom
claude-ra-ai-addressBusiness

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Part of a series of PRs for #96093 — one PR per occurrence, as requested in the issue.

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

AI checks run locally
  • npm run typecheck-tsgo — passed
  • npm run lint-changed — passed
  • npm run react-compiler-compliance-check check <file> — passed

The full Jest suite and Storybook smoke test were not run: no unit/UI test renders these substep components, and the change is a like-for-like loader swap following an existing merged pattern. The human co-author should complete the manual Tests/QA steps below.

Fixed Issues

#96093
PROPOSAL:

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose to connect the account manually (Connect manually) and proceed through the flow until you reach the Business info step and specifically its Company address substep (AddressBusiness).
  3. To observe the loading state, open Chrome DevTools > Network and set throttling to Slow 3G, then navigate into the Company address substep so the reimbursement account data is still loading when the substep renders.
  4. Verify that while the data loads, a centered loading spinner is shown and the step header and the Back (<) button remain visible — the spinner must NOT cover the back button with a full-screen overlay.
  5. Tap the Back button while the spinner is visible and verify it navigates back to the previous step as expected.
  6. Let the loading finish and verify the Company address form renders correctly, and that you can fill in the address fields and continue to the next step without any regression.
  7. Verify that no errors appear in the JS console.

Offline tests

  1. Repeat steps 1–2 above to reach the Business info > Company address substep.
  2. Turn off your network connection and navigate into the Company address substep.
  3. Verify that if a loading state is shown, it is the centered spinner with the step header and Back button still visible (no full-screen overlay), and that the Back button remains usable.

QA Steps

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Company address substep.
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Company address form renders and works normally (fields can be entered and you can continue to the next step) with no regressions.
  6. Verify that no errors appear in the JS console.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 23, 2026 03:54
@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check here is PR Author Checklist / checklist — and it's failing because the checklist boxes aren't ticked (0 out of 38 completed), not because of anything wrong with the code:

PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Every other check is passing or still running; none are red for a code reason.

This isn't something I can fix by pushing to the branch — the author checklist is meant to be completed by the human co-author, and the PR body still has the // TODO placeholders in the Tests and QA Steps sections. Once you fill out the checklist and those sections and check the boxes, this check will go green.

Let me know if you spot a different check failing and I'll take another look.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ount/USD/BusinessInfo/subSteps/AddressBusiness.tsx 0.00% <0.00%> (ø)
... and 915 files with indirect coverage changes

@situchan

situchan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot add Tests/QA steps

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Added Tests, Offline tests, and QA Steps to the PR body, situchan.

They walk a reviewer/QA through reaching the Business info → Company address substep of the USD Connect-bank-account (VBBA) flow and, while the reimbursement account data is loading, verifying the new centered spinner keeps the step header and Back button visible (instead of the old full-screen overlay that covered it), that Back still works mid-load, and that the address form renders and submits normally afterward with no console errors. The steps note using DevTools throttling / a High Traffic account to make the brief loading state observable.

I left every checkbox unchecked — the human co-author still needs to actually run these and capture the platform screenshots before marking the PR ready for review.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is PR Author Checklist / checklist — nothing is wrong with the code, and every functional check (tests, typecheck, ESLint, Oxfmt, React Compiler, Storybook, builds) is passing.

It fails only because the checklist boxes aren't ticked:

You completed 0 out of 38 checklist items with 38 unfinished items
PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

There's no fix for me to push here — the PR Author Checklist is a human-only step, and I won't check those boxes (or fill the Tests/QA/screenshot sections) on your behalf. As the assignee/co-author, please review each item, check the boxes, and complete the manual testing sections; the check will pass on the next run.

Full check status

Failing:

  • PR Author Checklist / checklist — 0/38 boxes checked (manual step)

All other checks pass or are skipped (tests jobs 1–8, typecheck, ESLint, Oxfmt, React Compiler Compliance, Storybook tests, Bun tests, builds, spellcheck, perf tests, codecov, snyk, CLA, etc.).

};
return <FullScreenLoadingIndicator reasonAttributes={reasonAttributes} />;
return (
<View style={[styles.flex1, styles.alignItemsCenter, styles.justifyContentCenter]}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot use styles.fullScreenLoading and remove styles.alignItemsCenter, styles.justifyContentCenter

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 897f0c8 — switched to AddressBusiness.tsx:58:

<View style={[styles.flex1, styles.fullScreenLoading]}>

styles.fullScreenLoading already sets justifyContent: 'center' and alignItems: 'center', so alignItemsCenter/justifyContentCenter were redundant and are removed. typecheck-tsgo, lint, and the React Compiler check pass on the file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot apply same to all other 11 PRs in #96093 (comment)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot apply same fix to all other 11 PRs in #96093 (comment)

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Both currently-failing checks are manual, human-only checklist steps — there's still no code problem and nothing for me to push:

  • PR Author Checklist / checklist — fails because the author checklist boxes aren't ticked (0/38). As assignee/co-author, check each box and complete the Tests/QA/screenshot sections.
  • PR Reviewer Checklist / checklist — fails with No PR Reviewer Checklist was found; it clears once a reviewer posts their completed reviewer checklist.

Every functional check (tests, typecheck, ESLint, Oxfmt, React Compiler, Storybook, Bun tests, builds, spellcheck, perf, codecov, snyk, CLA) is passing, so there's no fix to commit.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

After your new commit (Use styles.fullScreenLoading for AddressBusiness loading state), all functional checks pass — the only failing check is still PR Author Checklist / checklist, and there's nothing for me to fix in code.

That check fails only because the 38 author-checklist boxes aren't ticked (0 out of 38 completed). It's a human-only step, so I won't check the boxes (or fill the Tests/QA/screenshot sections) on your behalf. As the assignee/co-author, please complete the checklist and it'll pass on the next run.

The baseline-perf-tests / branch-perf-tests checks are still running at the time of writing; they passed on the previous commit, and a loading-state style swap isn't expected to affect them. If perf tests do fail once they finish, re-tag me and I'll take a look — but a perf-threshold failure typically needs a human judgment call rather than an automatic push.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — added Tests, Offline tests, and QA Steps to the other 11 PRs from #96093 (comment), each tailored to that PR's specific substep:

USD BusinessInfo substeps

USD Requestor/PersonalInfo

NonUSD

Every set walks a reviewer/QA to the relevant Reimbursement Account step/substep and, while the account data is loading, verifies the new centered spinner keeps the step header and Back button visible (instead of the old full-screen overlay), that Back still works mid-load, and that the form renders and submits normally afterward with no console errors. They note using DevTools throttling / a High Traffic account to make the brief loading state observable.

All checkboxes are left unchecked — the human co-author on each PR still needs to actually run the steps and attach the platform screenshots before marking it ready for review.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Applied the same fix — [styles.flex1, styles.fullScreenLoading] in place of [styles.flex1, styles.alignItemsCenter, styles.justifyContentCenter] (since fullScreenLoading already centers) — to all 11 other PRs in the series, situchan. Each is a one-line change pushed to the PR branch:

PR Substep Commit
#96830 IncorporationDateBusiness 56b817bd089
#96831 IncorporationStateBusiness 8a93a134b24
#96832 PhoneNumberBusiness 98af385036a
#96833 TaxIdBusiness c5590bf214e
#96834 TypeBusiness 94f2381373d
#96836 WebsiteBusiness 1edf7f3e689
#96837 PersonalInfo e594765c6c6
#96838 Address 84e41189b02
#96839 DateOfBirth 1bee7fa29b7
#96840 SocialSecurityNumber 279a37c8521
#96841 BusinessInfo (NonUSD) 18ef65563a5

Each change is byte-identical to the one you verified here on #96829 (typecheck-tsgo, lint, and the React Compiler check passed on that file), so I mirrored it rather than re-running the suite on all 11 branches.

@situchan

situchan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Company address substep.
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Company address form renders and works normally (fields can be entered and you can continue to the next step) with no regressions.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

8-AddressBusiness.mov
8-AddressBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above
And mark as ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Company address substep.
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Company address form renders and works normally (fields can be entered and you can continue to the next step) with no regressions.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

8-AddressBusiness.mov
8-AddressBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above
And mark as ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please check all items on the author checklist. I also verified this across all platforms.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done, situchan — checked all 38 items on the PR Author Checklist based on your explicit attestation that you verified this across all platforms. The PR Author Checklist / checklist check should go green on the next run.

I left the rest of the body untouched, and I didn't flip the PR out of draft since you only asked me to complete the checklist — let me know if you'd also like it marked ready for review.

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review August 3, 2026 21:20
@MelvinBot
MelvinBot requested a review from a team as a code owner August 3, 2026 21:20
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team August 3, 2026 21:20
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

@melvin-bot
melvin-bot Bot requested review from mollfpr and removed request for a team August 3, 2026 21:20
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
8-AddressBusiness-mobile.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
8-AddressBusiness.mov

@melvin-bot melvin-bot Bot changed the title Refactor BusinessInfo AddressBusiness loader to ActivityIndicator [Payment due @situchan] Refactor BusinessInfo AddressBusiness loader to ActivityIndicator Aug 3, 2026
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@mollfpr
mollfpr merged commit dc07065 into main Aug 4, 2026
47 of 52 checks passed
@mollfpr
mollfpr deleted the claude-ra-ai-addressBusiness branch August 4, 2026 14:31
@OSBotify

OSBotify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.50-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I reviewed this PR against Expensify's help site articles under App/docs/articles and no help site changes are required.

Why: This is a purely internal UI refactor — it swaps a FullScreenLoadingIndicator for a centered ActivityIndicator in the Reimbursement Account Business info → Company address (AddressBusiness) substep so the step header and Back button stay visible while data loads (per UI-1). It changes only how the transient loading state renders — no user-facing feature, workflow, tab, setting, label, button, or copy is added or changed.

Help articles document how to use features (e.g. connecting a business bank account and entering company info), not the internal loading-indicator implementation, so there's nothing in App/docs/articles that this change makes stale. No draft PR was created.

@situchan, if you believe a documented behavior actually changed here, let me know and I'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants