Skip to content

[Payment due @situchan] Refactor BusinessInfo IncorporationStateBusiness loader to ActivityIndicator - #96831

Open
MelvinBot wants to merge 2 commits into
mainfrom
claude-ra-ai-incorporationStateBusiness
Open

[Payment due @situchan] Refactor BusinessInfo IncorporationStateBusiness loader to ActivityIndicator#96831
MelvinBot wants to merge 2 commits into
mainfrom
claude-ra-ai-incorporationStateBusiness

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Part of a series of PRs for #96093 — one PR per occurrence, as requested in the issue.

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

AI checks run locally
  • npm run typecheck-tsgo — passed
  • npm run lint-changed — passed
  • npm run react-compiler-compliance-check check <file> — passed

The full Jest suite and Storybook smoke test were not run: no unit/UI test renders these substep components, and the change is a like-for-like loader swap following an existing merged pattern. The human co-author should complete the manual Tests/QA steps below.

Fixed Issues

#96093
PROPOSAL:

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose to connect the account manually (Connect manually) and proceed through the flow until you reach the Business info step and specifically its Incorporation state substep (the substep that asks for the company's state of incorporation).
  3. To observe the loading state, open Chrome DevTools > Network and set throttling to Slow 3G, then navigate into the Incorporation state substep so the reimbursement account data is still loading when the substep renders.
  4. Verify that while the data loads, a centered loading spinner is shown and the step header and the Back (<) button remain visible — the spinner must NOT cover the back button with a full-screen overlay.
  5. Tap the Back button while the spinner is visible and verify it navigates back to the previous step as expected.
  6. Let the loading finish and verify the Incorporation state form renders correctly, and that you can fill it in and continue to the next step without any regression.
  7. Verify that no errors appear in the JS console.

Offline tests

  1. Repeat steps 1–2 above to reach the Business info > Incorporation state substep.
  2. Turn off your network connection and navigate into the Incorporation state substep.
  3. Verify that if a loading state is shown, it is the centered spinner with the step header and Back button still visible (no full-screen overlay), and that the Back button remains usable.

QA Steps

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation state substep (the substep that asks for the company's state of incorporation).
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Incorporation state form renders and works normally, and you can continue to the next step with no regressions.
  6. Verify that no errors appear in the JS console.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…dicator

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 23, 2026 03:55
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Nothing to fix here in code — the only failing check is PR Author Checklist / checklist, and it's failing for a non-code reason.

The job log shows:

You completed 0 out of 38 checklist items with 38 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Every real check (Bun tests, test (job 1–8), ESLint, Oxfmt, typecheck-adjacent, React Compiler Compliance, Storybook, spellcheck, etc.) is passing; the remaining builds/perf checks are still pending, not failed.

This check turns green once the PR Author Checklist is completed — which is a human co-author task, not something I can resolve by pushing code:

  • Check off the 38 checklist boxes in the PR description.
  • Fill in the Tests and QA Steps sections (currently // TODO) and attach screenshots/videos per platform.

No code push is warranted for this failure.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...sinessInfo/subSteps/IncorporationStateBusiness.tsx 0.00% <0.00%> (ø)
... and 912 files with indirect coverage changes

@situchan

situchan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot add Tests/QA steps

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Here are suggested Tests / QA steps for this loader-swap. The change only affects the loading state of the BusinessInfo → "Which state was the company incorporated in?" substep (IncorporationStateBusiness.tsx:49-62), so the steps focus on (a) confirming the loading indicator no longer covers the step header/Back button (the UI-1 fix) and (b) confirming there's no regression once the step is loaded. A co-author should verify these before marking the PR ready.

Tests

  1. Sign in and open a workspace where you can connect a business bank account for reimbursements (Workspace → WorkflowsConnect bank account, USD).
  2. Proceed through the flow to the Business info step and advance through the substeps until you reach "Which state was the company incorporated in?" (the incorporation-state selector).
  3. To observe the loading state, open browser DevTools → Network and set throttling to Slow 3G, then navigate to the incorporation-state substep. While the reimbursement-account data loads:
    • Verify a centered spinner is shown.
    • Verify the step header and Back button at the top stay visible and tappable — the spinner must not paint a full-screen overlay over them (this is the behavior this PR fixes).
  4. Once loaded, verify the state selector renders, you can pick a state, and Next advances to the following substep.
  5. Tap Back from this substep and confirm it returns to the previous substep as expected.
  6. Verify that no errors appear in the JS console throughout.

Offline tests

  1. With the incorporation-state substep loaded, go offline.
  2. Verify the state selector and Back button still behave as expected and no full-screen loading overlay appears.

QA Steps

  1. On staging, sign in and start the Connect bank account (USD reimbursements) flow for a workspace.
  2. Reach the Business info step and advance to "Which state was the company incorporated in?".
  3. Verify that while the page is loading, the step header and Back button remain visible (no full-screen loading indicator covering them), and a centered spinner is shown instead.
  4. Verify the state selector loads, a state can be selected, Next advances, and Back returns to the previous substep.
  5. Verify that no errors appear in the JS console.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is PR Author Checklist / checklist, and it's failing because the checklist boxes are unchecked, not because of a code problem:

You completed 0 out of 38 checklist items with 38 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Every other check (ESLint, typecheck, Jest, Storybook, build, perf, etc.) is passing. This one can only be cleared by a human ticking the PR Author Checklist boxes in the description after completing the manual Tests/QA steps — there's nothing for me to push a code fix for here.

situchan — once you've gone through the checklist and checked the items off, this check will re-run and pass.

@situchan

situchan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation state substep (the substep that asks for the company's state of incorporation).
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Incorporation state form renders and works normally, and you can continue to the next step with no regressions.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

@MelvinBot please set the PR body to the content in the details section above
And mark as ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@situchan

situchan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

  1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
  2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Incorporation state substep (the substep that asks for the company's state of incorporation).
  3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
  4. Verify tapping Back while the spinner is visible navigates back as expected.
  5. After loading completes, verify the Incorporation state form renders and works normally, and you can continue to the next step with no regressions.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

11-IncorporationStateBusiness.mov
11-IncorporationStateBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please check all items on the author checklist. I also verified this across all platforms.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Checked off all 38 items in the PR Author Checklist — the PR Author Checklist / checklist check will re-run and go green now that 0 boxes remain unchecked. Thanks for confirming you verified this across all platforms, situchan.

For my own due diligence I also statically verified the one-file change against the pattern it claims to mirror:

Verification details
  • The loader swap in IncorporationStateBusiness.tsx:54-62 matches the already-merged BankInfo pattern in BankInfo.tsx:108-115 — a centered View wrapping ActivityIndicator rather than a full-screen overlay.
  • ActivityIndicator requires reasonAttributes and forwards size via ...rest, so the existing skeleton-span telemetry is preserved.
  • styles.fullScreenLoading centers content (justifyContent/alignItems: 'center') and is not absolutely positioned, so it fills the wrapper's content area without painting over the step header/Back button — which is the UI-1 fix this PR intends.
  • CONST.ACTIVITY_INDICATOR_SIZE.LARGE resolves. Typecheck/lint/react-compiler checks already passed per the PR body.

I attempted a live web drive of the Business info → Incorporation state loading state, but the browser session couldn't sign in (a transient environment/session issue, unrelated to this change), so I couldn't capture a runtime screenshot. The static review above plus your cross-platform verification cover the change.

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review August 3, 2026 21:25
@MelvinBot
MelvinBot requested a review from a team as a code owner August 3, 2026 21:25
@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team August 3, 2026 21:26
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Marked this PR as ready for review.

⚠️ I couldn't verify the loading state on web myself. Two blockers:

  • The shared web test tooling failed at sign-in (infra issue), so no app screen was reached.
  • Forcing this substep's loading state requires network throttling (Slow 3G), which the web test tool explicitly doesn't support — there's no supported throttling primitive.

The change itself is a like-for-like loader swap (IncorporationStateBusiness.tsx) that mirrors the already-merged BankInfo pattern, and typecheck-tsgo / lint-changed / react-compiler-compliance-check all passed locally. The manual Tests/QA steps and screenshots still need a human to complete against a VBBA-capable account with a throttled connection.

@melvin-bot
melvin-bot Bot requested review from danieldoglas and removed request for a team August 3, 2026 21:26
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan

situchan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
11-IncorporationStateBusiness-mobile.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
11-IncorporationStateBusiness.mov

@melvin-bot melvin-bot Bot changed the title Refactor BusinessInfo IncorporationStateBusiness loader to ActivityIndicator [Payment due @situchan] Refactor BusinessInfo IncorporationStateBusiness loader to ActivityIndicator Aug 3, 2026
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants