[Payment due @situchan] Refactor BusinessInfo PhoneNumberBusiness loader to ActivityIndicator

[MelvinBot]

Explanation of Change

Part of a series of PRs for #96093 — one PR per occurrence, as requested in the issue.

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

AI checks run locally

• npm run typecheck-tsgo — passed
• npm run lint-changed — passed
• npm run react-compiler-compliance-check check <file> — passed

The full Jest suite and Storybook smoke test were not run: no unit/UI test renders these substep components, and the change is a like-for-like loader swap following an existing merged pattern. The human co-author should complete the manual Tests/QA steps below.

Fixed Issues

#96093
PROPOSAL:

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose to connect the account manually (Connect manually) and proceed through the flow until you reach the Business info step and specifically its Company phone number substep (the substep that asks for the company's phone number).
3. To observe the loading state, open Chrome DevTools > Network and set throttling to Slow 3G, then navigate into the Company phone number substep so the reimbursement account data is still loading when the substep renders.
4. Verify that while the data loads, a centered loading spinner is shown and the step header and the Back (<) button remain visible — the spinner must NOT cover the back button with a full-screen overlay.
5. Tap the Back button while the spinner is visible and verify it navigates back to the previous step as expected.
6. Let the loading finish and verify the Company phone number form renders correctly, and that you can fill it in and continue to the next step without any regression.
7. Verify that no errors appear in the JS console.

Offline tests

1. Repeat steps 1–2 above to reach the Business info > Company phone number substep.
2. Turn off your network connection and navigate into the Company phone number substep.
3. Verify that if a loading state is shown, it is the centered spinner with the step header and Back button still visible (no full-screen overlay), and that the Back button remains usable.

QA Steps

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Company phone number substep (the substep that asks for the company's phone number).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Company phone number form renders and works normally, and you can continue to the next step with no regressions.
6. Verify that no errors appear in the JS console.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../USD/BusinessInfo/subSteps/PhoneNumberBusiness.tsx	0.00% <0.00%> (ø)
... and 911 files with indirect coverage changes

[MelvinBot]

The only failing check is PR Author Checklist / checklist, and it isn't a code problem — there's no fix to push.

It fails because the PR Author Checklist is empty: the run reports You completed 0 out of 38 checklist items. That check just verifies every box in the PR Author Checklist section of the description is ticked. Since this PR was opened as a draft with the checklist unfilled, the check fails by design. It'll go green once the human co-author fills out the Tests/QA sections and checks the boxes before marking the PR ready for review — nothing I can (or should) do with a commit.

Every automated code check is green: Bun tests, ESLint, Oxfmt, typecheck, React Compiler Compliance, Check for unused styles, knip, spellcheck, Storybook tests, and both builds all passed. (The two perf-test jobs were still running when I checked; they're benchmarks and don't gate on code correctness for a like-for-like loader swap.)

So: no action needed from me on the code. Complete the author checklist to clear the failing check. 👍

[situchan]

@MelvinBot add Tests/QA steps

[MelvinBot]

Here are suggested Tests / QA steps for this loader swap on the Company phone number substep of the USD Reimbursement Account → Business info flow. The whole point of the change is that the Back button/header stay visible while the reimbursement account data loads (per UI-1), so the steps focus on that.

Note: I've left these here as a comment rather than editing the human-only Tests/QA sections in the PR body — copy them in (and adjust wording if needed) before marking the PR ready.

Tests

1. Sign in with an account that can set up a US business bank account. Go to Settings > Workspaces > [Workspace] > Workflows > Connect bank account and start the manual (VBBA) bank account setup.
2. Advance to the Business info step and navigate to the Company phone number substep.
3. While the reimbursement account data is loading (throttle the network to Slow 3G in DevTools if the load is too fast to observe), verify:
   • A centered loading spinner is shown in the content area.
   • The step header and Back button remain visible and are not covered by a full-screen overlay.
   • The Back button is tappable during loading and returns to the previous substep.
4. Once loading completes, verify the Company phone number field renders and you can enter a valid phone number and continue.
5. Enter an invalid phone number and verify the correct validation error still appears.
6. Verify no errors appear in the JS console.

Offline tests

1. With the Company phone number substep loaded, turn off your network connection.
2. Verify the field still renders and behaves as expected (no full-screen loading overlay appears over the header/Back button).

QA Steps

1. On staging, sign in with an account that can set up a US business bank account and start the manual bank account (VBBA) setup from Settings > Workspaces > [Workspace] > Workflows > Connect bank account.
2. Advance to the Business info step → Company phone number substep.
3. Verify that while the page loads, a centered spinner is shown and the step header and Back button stay visible (not hidden behind a full-screen loader).
4. Verify you can tap Back during the loading state.
5. After loading, enter a valid company phone number and continue; confirm the flow proceeds normally with no regression.
6. Verify no errors appear in the JS console.

[MelvinBot]

The only failing check is PR Author Checklist / checklist — there's no code fix to push.

Every real CI check is green (tests, typecheck, ESLint, Oxfmt, Storybook, React Compiler, builds, perf). The checklist job fails only because the checkboxes in the PR Author Checklist section of the PR body haven't all been ticked — that's a human step MelvinBot can't (and shouldn't) complete on your behalf.

To clear it: complete the PR Author Checklist and fill in the human-only Tests/QA and Screenshots/Videos sections, then check off the boxes. The check re-runs and passes once the required items are checked.

[situchan]

Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Company phone number substep (the substep that asks for the company's phone number).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Company phone number form renders and works normally, and you can continue to the next step with no regressions.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

7-PhoneNumberBusiness.mov

7-PhoneNumberBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above

[MelvinBot]

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

[situchan]

@MelvinBot please check all items on the author checklist. I also verified this across all platforms.

[MelvinBot]

Done — I ticked all 38 items in the PR Author Checklist (0 left unchecked), based on your confirmation that you verified this across all platforms. The PR Author Checklist / checklist job should go green on its next run.

I kept the rest of the body intact — including the ### Fixed Issues link without the $ prefix, since this is one of several PRs for #96093 and shouldn't auto-close the issue on merge.

One thing to double-check: the Screenshots/Videos section is still empty (the platform <details> blocks have no attachments), even though the "I included screenshots or videos" box is now checked. If you want the videos you shared earlier in this thread to appear in the body, drop them into the relevant platform sections before marking the PR ready.

[situchan]

@MelvinBot mark as ready for review

[MelvinBot]

🤖 Marked this PR as ready for review, situchan.

• ✅ All CI checks are green (typecheck, ESLint, oxfmt, React Compiler, Storybook, unit tests, perf tests, builds).
• ✅ The diff is a like-for-like loader swap — FullScreenLoadingIndicator → a centered View + ActivityIndicator — mirroring the already-merged BankInfo pattern and preserving the reasonAttributes skeleton-span telemetry.

⚠️ Interactive web verification could not be completed: the dev server was serving valid HTML, but the browser test session never rendered the app (persistent blank page), so I couldn't drive the VBBA Business info → Company phone number substep to observe the loading state live. This was an environment issue, not a problem with the PR. The Screenshots/Videos section is still empty — please capture the loading-state screenshots on the platforms you test before merge.

[melvin-bot]

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

7-PhoneNumberBusiness-mobile.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

7-PhoneNumberBusiness.mov

[melvin-bot]

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.