Skip to content

[CP Staging] Revert server-driven AZ status on expense reports#97003

Merged
yuwenmemon merged 1 commit into
mainfrom
yuwen-revert-95959
Jul 24, 2026
Merged

[CP Staging] Revert server-driven AZ status on expense reports#97003
yuwenmemon merged 1 commit into
mainfrom
yuwen-revert-95959

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@roryabraham please review

Explanation of Change

Reverts #95959, which lets non-chat reports mount the AgentZero status gate. On expense reports this makes a Concierge "thinking" indicator flash briefly during unrelated actions such as inviting a member, which is a deploy blocker.

Because a large report-list refactor landed on top of #95959, this could not be reverted automatically. The AgentZero/Concierge changes were undone by hand while preserving that refactor: the expense-report tail indicator and its provider wrappers are removed, and the ReportActionsListTailIndicator rename is reverted back to ReportActionsListHeader.

Fixed Issues

$ #96979

PROPOSAL: N/A

Tests

  1. Open a workspace chat.
  2. Create two manual distance expenses.
  3. Open the expense report (the parent multi-expense report, not an individual transaction thread).
  4. Invite a user to the expense report.
  5. Verify no Concierge thinking indicator appears on the expense report at any point.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

  1. Open a workspace chat.
  2. Create two manual distance expenses.
  3. Open the expense report (the parent multi-expense report, not an individual transaction thread).
  4. Invite a user to the expense report.
  5. Verify no Concierge thinking indicator appears on the expense report at any point.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — revert.

Android: mWeb Chrome

N/A — revert.

iOS: Native

N/A — revert.

iOS: mWeb Safari

N/A — revert.

MacOS: Chrome / Safari

N/A — revert.

@yuwenmemon
yuwenmemon requested review from a team as code owners July 24, 2026 18:56
@melvin-bot
melvin-bot Bot requested review from heyjennahay and sobitneupane July 24, 2026 18:56
@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team July 24, 2026 18:56
@yuwenmemon
yuwenmemon requested a review from roryabraham July 24, 2026 19:33
@yuwenmemon yuwenmemon changed the title Revert server-driven AZ status on expense reports [CP Staging] Revert server-driven AZ status on expense reports Jul 24, 2026
@yuwenmemon
yuwenmemon merged commit b3e7147 into main Jul 24, 2026
46 checks passed
@yuwenmemon
yuwenmemon deleted the yuwen-revert-95959 branch July 24, 2026 19:36
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 24, 2026
yuwenmemon added a commit that referenced this pull request Jul 24, 2026
[CP Staging] Revert server-driven AZ status on expense reports

(cherry picked from commit b3e7147)

(cherry-picked to staging by yuwenmemon)
yuwenmemon added a commit that referenced this pull request Jul 24, 2026
…125181995-1

🍒 Cherry pick PR #97003 to staging 🍒
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.4.44-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site files under App/docs/articles.

No help site changes are required, so I did not create a draft PR.

Why: This PR is a revert of #95959. It stops non-chat reports (expense reports) from mounting the AgentZero status gate, which was causing a Concierge "thinking" indicator to flash briefly during unrelated actions like inviting a member. This is an internal UI/implementation fix that removes unintended behavior — it does not add or change any user-facing feature, setting, tab, or workflow that the help site documents.

I checked the help articles that reference Concierge (e.g. Concierge-in-Expensify.md) and they describe the Concierge assistant itself, not this transient loading indicator, so none of them are affected by this revert.

If you believe a specific article should be updated, reply with the article and the behavior it should describe and I'll draft the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants