🍒 Cherry pick PR #97003 to staging 🍒#97007
Conversation
(cherry picked from commit 3aaff28) (cherry-picked to staging by yuwenmemon)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cf46f87bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "name": "new.expensify", | ||
| "version": "9.4.44-5", | ||
| "version": "9.4.44-6", |
There was a problem hiding this comment.
Cherry-pick the revert before bumping staging
At this bump to 9.4.44-6, the commit is supposed to cherry-pick #97003's deploy-blocker revert, but the diff against the parent only changes version metadata and the Mobile-Expensify gitlink. The App-side revert is still absent in this tree (MoneyRequestReportView still wraps expense reports with AgentZeroStatusProvider, AgentZeroStatusContext still enables hasServerDrivenStatus, and ReportActionsListTailIndicator.tsx still exists), so deploying this version to staging will not remove the Concierge thinking indicator that the CP is meant to fix.
Useful? React with 👍 / 👎.
[CP Staging] Revert server-driven AZ status on expense reports (cherry picked from commit b3e7147) (cherry-picked to staging by yuwenmemon)
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.4.44-6 🚀
|
Help site review: no changes requiredI reviewed the changes in this PR (a cherry-pick of #97003) and no updates are required to the help site files under Why: This is a revert of a regression. It undoes server-driven AgentZero/Concierge status behavior on expense reports that caused a "thinking" indicator to flash briefly during unrelated actions (e.g. inviting a member). The diff:
None of this adds or changes a documented, user-facing feature, setting, tab, or button, and there is no help article describing this indicator's behavior. It simply returns the UI to its previously-documented state, so the existing help content remains accurate. If you feel a specific article should be updated anyway, let me know which behavior you'd like documented and I'll draft it. |
🍒 Cherry pick #97003 to staging 🍒
This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:
Then manually resolve conflicts, and commit the change with
git cherry-pick --continue. Lastly, please run:This last part is important. It will help us keep track of who triggered this CP, and will ensure that version bumps are tracked correctly. Once all that's done, push your changes with
git push origin cherry-pick-staging-97003-30125181995-1, and then open this PR for review.Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.
Important
This PR should ideally be merged by a member of the mobile-deployers team. If it is merged by someone who is not a deployer, the staging deploy triggered by the merge will fail and will need to be manually re-triggered (not just retried) via the deploy workflow.
Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari