Dev 0.2.40 Targeted as latest master/stable release#54
Conversation
- Added new method to log messages into a file during the F/W Update process. This replaces the previous method that was causing some issues when trying to unmount the USB-attached drive just before the F/W was updated. - Added code to show the F/W Update notification date on the menu. - Moved a few functions to the top.
Update MerlinAU.sh
Update MerlinAU.sh Logging Solution to Stop Duplicating Mount Points
Just a couple of changes to double-check that the LOG directory actually exists.
Version increment.
Version increment.
Set the wait times for the "curl" command to return and then for the reboot (if necessary) to 3 minutes each.
Updated MerlinAU.sh
Updated version.
Code changes WRT the blinking LEDs. Rather than stopping the blinking LEDs while waiting for a reboot, we restart them with a slower blinking rate to show users some activity is still going on but not the same as before when the curl cmd was being executed.
Added last LED reset *before* the reboot call.
Updated MerlinAU.sh
Added/modified code to output some trace log messages when the "_DoCleanUp_" & "_Reset_LEDs_" functions are called after the F/W Update process is completed. This should leave a trace indicating IF/WHEN the "cleanup" is done as expected, especially if the router reboots itself. This trace log is only temporary. We can switch it off later on once we have determined whether the "trap" mechanism is working after the F/W Update.
Update MerlinAU.sh
…G_LOGIC Update MerlinAU.sh ROG Logic
|
Merged all our improvements and hard work and troubleshooting into master/production. Merry Christmas!! Happy Holidays!! |
Let's open the champagne early & start toasting!! :>) |
I never really went to sleep last night. I got a couple hours of zzz's |
|
Just realized for me the script doesn't seem to run as a Cron job anymore :( If I run other scripts in the jffs/scripts folder as crons they work normally. But that command as a cron job seems to do nothing for me. I adjusted the cron to be every 1 minute and I have an update available and it still is doing nothing, while the other script I have to ping google every mintue is working fine on the same cron schedule. Will troubleshoot some more tomorrow. |
That's a very odd behavior. Just to clarify: the cron job "hook" is indeed found in the "/jffs/scripts/services-start" file, and the cron job entry does exist under crontab BUT when the job actually runs via cron nothing happens. However, running the same command manually via CLI "sh /jffs/scripts/MerlinAU.sh run_now" works fine, so something in the cron mechanism appears to fail when calling the script. Is my understanding correct? |
OK, on a hunch I put a log message before and after the code that prevents running the script multiple times simultaneously, and that's where it fails because it gets 2 processes running when called from crontab. So I know what the problem is and I'm working on a fix. Good catch, buddy!!! |
No, whats a good catch is how you just freaking knew that on a whim/hunch!!! Like wth?!?! No testing? No troubleshooting? No need! Martins on the case! Hahaha. |
Sometimes, your intuition (based on accummulated knowledge/experience) points you in the right direction and you just get lucky!! :>) |
2 participants
Dev 0.2.40 Targeted as latest master/stable release