pimd: Keep track of how long the S,G rpt Prune has been around (backport #20576)#20583
Conversation
The S,G rpt prune ifchannel was not tracking uptime. Let's do so. Signed-off-by: Donald Sharp <sharpd@nvidia.com> (cherry picked from commit d397f86)
Greptile SummaryAdded missing uptime tracking for S,G RPT prune ifchannel state transitions. Previously, the
This change ensures consistent uptime tracking across all relevant state transitions, making the Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as pim_ifchannel_prune()
participant Ch as pim_ifchannel (ch)
participant Timer as Event System
Note over Caller,Ch: Case 1: JOIN -> PRUNE_PENDING
Caller->>Ch: Receive Prune message
Ch->>Ch: Set ifjoin_creation = pim_time_monotonic_sec()
Ch->>Ch: Switch state: JOIN -> PRUNE_PENDING
Ch->>Timer: Start prune_pending_timer
Note over Caller,Ch: Case 2: PRUNE_PENDING_TMP -> PRUNE_PENDING (RPT bit set)
Caller->>Ch: Receive Prune message with RPT bit
Ch->>Ch: Set ifjoin_creation = pim_time_monotonic_sec()
Ch->>Ch: Set state: PRUNE_PENDING_TMP -> PRUNE_PENDING
Ch->>Timer: Cancel expiry_timer
Ch->>Timer: Start new expiry_timer with holdtime
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
The S,G rpt prune ifchannel was not tracking uptime. Let's do so.
This is an automatic backport of pull request #20576 done by Mergify.