babeld: fix NULL pointer dereference in babel_clean_routing_process (backport #20727)#20850
Merged
donaldsharp merged 1 commit intostable/10.5from Feb 16, 2026
Merged
Conversation
When babeld receives an exit signal (SIGINT/SIGTERM) during shutdown or when `babel_routing_process` is NULL (never initialized or already freed), the program crashes with SIGSEGV due to a NULL pointer dereference in `babel_clean_routing_process()`. The function accesses `babel_routing_process->t_read` and `babel_routing_process->t_update` without checking if `babel_routing_process` is NULL first. This can occur when: 1. The program receives an exit signal before `babel_routing_process` is fully initialized 2. `babel_routing_process` initialization fails but the cleanup function is still called 3. The cleanup function is called multiple times Fix: Add early return if babel_routing_process is NULL, and set it to NULL after freeing to prevent double-free issues. Signed-off-by: LyZephyr <yunzheli@smail.nju.edu.cn> (cherry picked from commit cb76f18)
|
Target branch is not in the allowed branches list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When babeld receives an exit signal (SIGINT/SIGTERM) during shutdown or when
babel_routing_processis NULL (never initialized or already freed), the program crashes with SIGSEGV due to a NULL pointer dereference inbabel_clean_routing_process(). The function accessesbabel_routing_process->t_readandbabel_routing_process->t_updatewithout checking ifbabel_routing_processis NULL first.This can occur when:
babel_routing_processis fully initializedbabel_routing_processinitialization fails but the cleanup function is still called