Labels: bug, parity, verification, priority:high
File: src/tether/verify.py:395 (gather_paired_samples), src/tether/runtime/fast_inference/libero_adapter.py:53-89 (from_policy rebuilds from native float32), TODO admission at verify.py:387
Description. The "optimized" arm is built via TritonLIBEROAdapter.from_policy(policy) where policy is the native PyTorch checkpoint, not the export under test. The export dir is only read for the expert_takes_state flag; its .onnx/.trt/.data files are never loaded.
Why it matters. A customer exports a numerically-broken ONNX (bad opset, dropped Cast, weight-fusion bug), runs tether verify ./export, and both arms share the same native weights → parity is trivially high → PASS. The exact regression verify exists to catch is invisible. This directly undermines the product's "deployment confidence" pitch.
Tasks.
Dedup. #104 is the round-trip "mirror bug" blindspot; #30/#31 add cosine/pi0.5 to round-trip validation; #198 (PR) is the action-parity metric engine. None make verify load the exported graph. Distinct.
Labels:
bug,parity,verification,priority:highFile:
src/tether/verify.py:395(gather_paired_samples),src/tether/runtime/fast_inference/libero_adapter.py:53-89(from_policyrebuilds from native float32), TODO admission atverify.py:387Description. The "optimized" arm is built via
TritonLIBEROAdapter.from_policy(policy)wherepolicyis the native PyTorch checkpoint, not the export under test. The export dir is only read for theexpert_takes_stateflag; its.onnx/.trt/.datafiles are never loaded.Why it matters. A customer exports a numerically-broken ONNX (bad opset, dropped Cast, weight-fusion bug), runs
tether verify ./export, and both arms share the same native weights → parity is trivially high → PASS. The exact regression verify exists to catch is invisible. This directly undermines the product's "deployment confidence" pitch.Tasks.
tether_config.json["export_kind"]→ ORT / decomposed / Triton-from-engine) for the optimized arm.from_policy.Dedup. #104 is the round-trip "mirror bug" blindspot; #30/#31 add cosine/pi0.5 to round-trip validation; #198 (PR) is the action-parity metric engine. None make
verifyload the exported graph. Distinct.