Skip to content

fix(ci): flatten policy approval download - #325

Merged
rylinjames merged 1 commit into
mainfrom
codex/approval-download-291
Aug 28, 2026
Merged

fix(ci): flatten policy approval download#325
rylinjames merged 1 commit into
mainfrom
codex/approval-download-291

Conversation

@rylinjames

Copy link
Copy Markdown
Collaborator

Summary

  • flatten the exact approval artifact into the verifier's declared target directory
  • add regression coverage for the ordinary protected-ratchet download layout

Live evidence

Protected run 33165642340 completed successfully and the ordinary verifier accepted its status, run, and artifact ID. Attempt 2 of ordinary run 33165637778 then failed only because download-artifact placed quality-policy-approval.json under an artifact-ID subdirectory. This applies the documented merge-multiple flattening already used by the protected validation path.

Validation

  • 16 focused quality-ratchet tests pass
  • workflow YAML parses
  • focused Ruff and diff checks pass

Final bootstrap follow-up for #291. The self-protected ratchet failure is expected; all ordinary checks must pass before audited admin merge.

@rylinjames

Copy link
Copy Markdown
Collaborator Author

Independent review: APPROVE. The reviewer confirmed merge-multiple only flattens the already-selected single artifact ID; exact artifact name/unexpired/digest, repository, run ID, candidate/base SHA, workflow, and validation-artifact bindings remain unchanged and fail closed. Live attempt 2 selected artifact 9683482457 but extracted under its name with merge=false. Reviewer validation: 16 tests, Ruff format/check, YAML parse, and diff check passed.

@rylinjames

Copy link
Copy Markdown
Collaborator Author

Audited protected-workflow bootstrap: independent review is APPROVE and all ordinary pytest, doctor, and wheel checks are green. The sole failure is expected self-protection because this PR changes the protected ordinary ratchet workflow. Proceeding with an explicit admin squash merge without changing branch protection.

@rylinjames
rylinjames merged commit 112cba2 into main Aug 28, 2026
7 of 9 checks passed
@rylinjames
rylinjames deleted the codex/approval-download-291 branch August 28, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant