Skip to content

fix(ci): flatten policy approval download #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rylinjames merged 1 commit into from
Aug 28, 2026
Merged

fix(ci): flatten policy approval download #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/quality-ratchet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ jobs:
uses: actions/download-artifact@v4
with:
artifact-ids: ${{ steps.authorization.outputs.artifact_id }}
merge-multiple: true
path: ${{ runner.temp }}/approval-evidence
github-token: ${{ github.token }}
repository: ${{ github.repository }}
Expand Down
4 changes: 4 additions & 0 deletions tests/test_ci_quality_ratchet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ def test_workflows_separate_ordinary_and_protected_policy_changes() -> None:
assert '--expected-candidate-sha "$HEAD_SHA"' in ordinary
assert '--expected-base-sha "$BASE_SHA"' in ordinary
assert "artifact-ids: ${{ steps.authorization.outputs.artifact_id }}" in ordinary
approval_download = ordinary.split("- name: Download exact approval evidence", 1)[1].split(
"- name: Verify immutable approval evidence binding", 1
)[0]
assert "merge-multiple: true" in approval_download
assert "Bind the event to the current protected-main tip" in ordinary
assert "--verify-main-ref-response" in ordinary
assert "--expected-current-main-sha" in ordinary
Expand Down
Loading