chore(project): audit readiness and consolidate browser fixtures - #55
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f369981d4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary Issue
Closes #53
Also closes #57
Refs #44
Problem And Outcome
Fresh contributors received contradictory status and repeated guidance; CI
never exercised the shipped browser workflows. Five specs also duplicated
server management, accepted any healthy process on a fixed port, and did not
await shutdown. This change makes context task-directed and gives test
installations one lifecycle owner.
Changes
CONTRIBUTING.md owns workflow detail; docs/development.md maps tasks to
source, ADRs, formats, and tests. Tool entrypoints remain thin.
snapshot-bound authorization is a packet-path property, not a universal
guarantee. Clarify ADR 0011's already-enforced ASCII member-name restriction.
Playwright fixture. Each test gets an OS-assigned loopback port and scratch
installation; readiness requires the child to announce its bound listener.
Shutdown is awaited before scratch data is deleted on both pass and failure.
Startup diagnostics exclude setup codes.
distinct installation ports, shutdown, cleanup, and diagnostic redaction.
declarations. Add the explicit binary build and browser suite to CI.
remains a separate repair in storage(doctor): diagnose without changing persisted journal mode #56; the guides now qualify that contract.
Scope
ownership, typechecking, existing-workflow CI coverage, preview runbook.
implementation, remaining linked defects, or preview deployment changes.
Verification
with no missing file targets.
(five original scenarios and three new fixture tests: 8 passed in 29.4s)
The first explicit browser typecheck failed with missing Node declarations
(TS2307); the new development dependency and check configuration correct it.
The preexisting low-severity npm advisory chain remains tracked in #54.
The doctor reproduction used a scratch toy database; its expected
missing-schema exit is distinct from the observed journal-mode mutation.
CI at 3a6cd8e passed the added browser stage before the fixture consolidation.
CI at 3d87379 also passed the consolidated fixture and browser TypeScript checks.
Final head 424f01e only links the remaining audit ownership work to #58 and #59;
its full gate is https://github.com/FieldmouseWorks/consolebook/actions/runs/33928869139.
All fixtures are invented. No production recovery claim.
Review And Merge Notes
Review the authority/context split, snapshot-authorization qualification,
fixture resource ownership/failure paths, and browser CI step. The dated
audit lists unresolved work without claiming those contracts repaired.
The public preview remains on its separately installed release binary.