fix(studio): filter verify-list by active field#7
Open
febuz wants to merge 1 commit into
Open
Conversation
Facts and terms from every field were shown regardless of the selected field button — setField() only toggled UI chrome, never filtered #verify-list. Tag each row with its field on creation and hide rows that don't match currentField, both on insert and on field-switch, so e.g. selecting intelfield/ledgerfield no longer surfaces finfield's AAPL facts. Fixes #3 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YWdCFgiCtzULqt4Sez2EC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#verify-listwas seeded with facts/terms from every field and never filtered — selecting intelfield/ledgerfield still showed FinField's AAPL facts.dataset.fieldon creation, hide it if it doesn't matchcurrentField, and re-filter on everysetField()call (both for newly-inserted rows and on field-switch).<field>yet" placeholder, distinct from the existing all-fields-empty message.Implements the surgical fix already specified in #3.
Fixes #3
Test plan
node --check web/studio/fin-engine.js— syntax valid🤖 Generated with Claude Code