Skip to content

fix(studio): filter verify-list by active field #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
febuz wants to merge 1 commit into
base: fin-studio
Choose a base branch
from
Open

fix(studio): filter verify-list by active field #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions web/studio/fin-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,8 @@ function fmtValue(f) {
function votableRow(engine, item) {
const row = document.createElement("div");
row.className = "card vrow";
row.dataset.field = item.field;
row.hidden = item.field !== currentField;
const isFact = item.kind === "finfact-record";
const fieldTag = `<span class="field-tag ${esc(item.field)}">${esc(item.field)}</span>`;
let head, body, prov;
Expand Down Expand Up @@ -375,6 +377,19 @@ async function wireStudio(engine) {
$("k-field-label").textContent = field;
// The integer-only fact path is finfield-only.
$("propose-section").classList.toggle("hidden", field !== "finfield");
// Filter the verify list to this field only — facts/terms from other
// fields must never show up here (each field is its own domain knitweb).
let shown = 0;
for (const r of document.querySelectorAll("#verify-list .vrow")) {
const on = r.dataset.field === field;
r.hidden = !on;
shown += on ? 1 : 0;
}
$("verify-empty")?.remove();
if (!shown && document.querySelectorAll("#verify-list .vrow").length) {
$("verify-list").insertAdjacentHTML("beforeend",
`<p id="verify-empty" class="dim">nothing to verify in ${esc(field)} yet — knit a term above.</p>`);
}
};
for (const b of document.querySelectorAll(".field-btn"))
b.addEventListener("click", () => setField(b.dataset.field));
Expand Down
Loading