fix(trait/value)raise validation error if trait_value is too long - #307
Merged
Conversation
matthewelwell
requested changes
Sep 13, 2021
|
|
||
| if data_type == STRING and len(data) > TRAIT_VALUE_MAX_LENGTH: | ||
| raise serializers.ValidationError( | ||
| "Value string is too long. Must be less than 2000 character" |
Contributor
There was a problem hiding this comment.
Suggested change
| "Value string is too long. Must be less than 2000 character" | |
| f"Value string is too long. Must be less than {TRAIT_VALUE_MAX_LENGTH} character" |
| from features.value_types import BOOLEAN, FLOAT, INTEGER, STRING | ||
|
|
||
| ACCEPTED_TRAIT_VALUE_TYPES = [INTEGER, STRING, BOOLEAN, FLOAT] | ||
| TRAIT_VALUE_MAX_LENGTH = 2000 |
Contributor
There was a problem hiding this comment.
We should be explicit here and specify it as something like:
TRAIT_STRING_VALUE_MAX_LENGTH = 2000
|
|
||
| # Then | ||
| assert res.status_code == status.HTTP_400_BAD_REQUEST | ||
| assert "string is too long" in res.json()["trait_value"][0] |
Contributor
There was a problem hiding this comment.
Why not assert the exact error message - it's not much more code.
matthewelwell
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #294