Skip to content

fix: enable usage cache by default#5356

Merged
gagantrivedi merged 3 commits intomainfrom
fix/enable-usage-cache
Apr 18, 2025
Merged

fix: enable usage cache by default#5356
gagantrivedi merged 3 commits intomainfrom
fix/enable-usage-cache

Conversation

@gagantrivedi
Copy link
Copy Markdown
Member

@gagantrivedi gagantrivedi commented Apr 18, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Enable USE_CACHE_FOR_USAGE_DATA by default (we always recommend enabling this; it's kind of a breaking change, but not really — let me know what you think).

Rename PG_API_USAGE_CACHE_SECONDS to API_USAGE_CACHE_SECONDS, since the cache now also covers Influx usage.

How did you test this code?

Please describe.

@gagantrivedi gagantrivedi requested a review from a team as a code owner April 18, 2025 07:48
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team April 18, 2025 07:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2025 10:15am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2025 10:15am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2025 10:15am

@github-actions github-actions Bot added api Issue related to the REST API infrastructure fix and removed infrastructure labels Apr 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5356 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5356 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5356 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5356 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5356 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5356 Finished ✅ Results

@gagantrivedi gagantrivedi requested a review from a team April 18, 2025 07:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2025

Uffizzi Preview deployment-62927 was deleted.

Comment thread api/app/settings/common.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (9974494) to head (975f803).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5356   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files        1237     1237           
  Lines       42957    42960    +3     
=======================================
+ Hits        41934    41937    +3     
  Misses       1023     1023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gagantrivedi gagantrivedi requested a review from a team as a code owner April 18, 2025 08:02
@gagantrivedi gagantrivedi requested review from Zaimwa9 and removed request for a team April 18, 2025 08:02
@github-actions github-actions Bot added docs Documentation updates infrastructure fix and removed fix infrastructure docs Documentation updates labels Apr 18, 2025
@github-actions github-actions Bot added docs Documentation updates infrastructure and removed fix infrastructure docs Documentation updates labels Apr 18, 2025
@github-actions github-actions Bot added the fix label Apr 18, 2025
@gagantrivedi gagantrivedi merged commit fdebe4f into main Apr 18, 2025
38 checks passed
@gagantrivedi gagantrivedi deleted the fix/enable-usage-cache branch April 18, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants