Skip to content

fix: Task processor overload when handling high volume SDK traffic#5358

Merged
khvn26 merged 2 commits intomainfrom
fix/force-track-request-run-in-thread
Apr 21, 2025
Merged

fix: Task processor overload when handling high volume SDK traffic#5358
khvn26 merged 2 commits intomainfrom
fix/force-track-request-run-in-thread

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Apr 21, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

After changes introduced in #5356 and #5330, we've been seeing noticeable task processor congestion. In this PR, we force request tracking to a threaded mode to avoid it.

How did you test this code?

Made sure the unit test suite passes.

@khvn26 khvn26 requested a review from a team as a code owner April 21, 2025 10:19
@khvn26 khvn26 requested review from matthewelwell and removed request for a team April 21, 2025 10:19
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 10:23am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 10:23am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 10:23am

@github-actions github-actions Bot added the api Issue related to the REST API label Apr 21, 2025
@khvn26 khvn26 requested review from gagantrivedi and removed request for matthewelwell April 21, 2025 10:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5358 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5358 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5358 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5358 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5358 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5358 Finished ✅ Results

@github-actions github-actions Bot added the fix label Apr 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2025

Uffizzi Preview deployment-62969 was deleted.

@github-actions github-actions Bot added fix and removed fix labels Apr 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (de92415) to head (dd44f87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5358   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files        1237     1237           
  Lines       42971    42971           
=======================================
  Hits        41948    41948           
  Misses       1023     1023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit 4b0ae75 into main Apr 21, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/force-track-request-run-in-thread branch April 21, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants