Skip to content

fix: reviewed-dependencies-and-mutualize-components - #6567

Merged
Zaimwa9 merged 2 commits into
mainfrom
fix/feature-limit-alert-infinite-loop
Jan 21, 2026
Merged

fix: reviewed-dependencies-and-mutualize-components#6567
Zaimwa9 merged 2 commits into
mainfrom
fix/feature-limit-alert-infinite-loop

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Dependencies array of FeatureLimitAlert was causing an infinite loop => updated to project values
  • Deduplicated calculations with different rounding between header a create flag modal

How did you test this code?

The app was becoming unresponsive

image

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner January 21, 2026 08:53
@Zaimwa9
Zaimwa9 requested review from talissoncosta and removed request for a team January 21, 2026 08:53
@vercel

vercel Bot commented Jan 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 21, 2026 11:48am
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 21, 2026 11:48am
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 21, 2026 11:48am

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Jan 21, 2026
@github-actions

github-actions Bot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6567 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6567 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6567 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6567 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6567 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6567 Finished ✅ Results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants