Skip to content

docs: Document supported SCIM features and correct the deprovisioning and base URL guidance - #8221

Merged
khvn26 merged 4 commits into
mainfrom
docs/scim-okta-feedback
Aug 5, 2026
Merged

docs: Document supported SCIM features and correct the deprovisioning and base URL guidance#8221
khvn26 merged 4 commits into
mainfrom
docs/scim-okta-feedback

Conversation

@khvn26

@khvn26 khvn26 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

In this PR, we address feedback from Okta OIN team:

  1. Add a "Supported features" section, and a table of the three user attributes we actually read.
  2. Correct the deprovisioning documentation
  3. Make the Okta section self-contained

How did you test this code?

Docs-only change

… base URL guidance

Adds a supported-features section and the three user attributes we actually
read, both asked for by the Okta OIN reviewers.

Also corrects three things the docs got wrong: deprovisioning works through
DELETE only (support for the `active` attribute was removed), the SCIM base
URL must not have a trailing slash, and the Okta section now says where the
base URL and token come from.

beep boop
@khvn26
khvn26 requested a review from a team as a code owner August 5, 2026 12:49
@khvn26
khvn26 requested review from matthewelwell and removed request for a team August 5, 2026 12:49
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 5, 2026 3:35pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Preview Aug 5, 2026 3:35pm
flagsmith-frontend-staging Ignored Ignored Preview Aug 5, 2026 3:35pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The SCIM documentation lists supported and unsupported features, supported user attributes, and DELETE-only deprovisioning. It updates SCIM URL and token setup guidance. The Okta guide adds configuration steps and documents unassignment-based deprovisioning. Troubleshooting now covers exact URL matching and the 501 response for active=false PATCH requests.

Estimated code review effort: 2 (Simple) | ~10 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The Okta section described the generic custom SCIM app flow: entering a SCIM
connector base URL, a unique identifier field, supported provisioning actions
and an HTTP Header auth mode. The Flagsmith OIN application has none of those
fields. It derives the SCIM base URL from the API Base URL set under Advanced
Sign-on Settings, and takes the bearer token as "API Token" under Provisioning
> Integration.

This matters because the submission's setup instructions link points at this
anchor, so Okta's reviewers follow these steps.

beep boop
Zaimwa9
Zaimwa9 previously approved these changes Aug 5, 2026

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Approving (to help unblocking) without knowledge of the exact requirements but I guessed improvements where about:

  • activate versus delete
  • trailing slashes ?
  • user attributes mapping
  • clear supported features

Which are clearly understandable from my pov

matthewelwell
matthewelwell previously approved these changes Aug 5, 2026
Comment thread docs/docs/administration-and-security/access-control/scim.md
The `apibaseUrl` tenant variable has no default in the OIN submission, and it
also feeds the SAML ACS URL template, so every customer sets it.

beep boop

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 84737384-9612-4d51-a887-28ccc91aa5cb

📥 Commits

Reviewing files that changed from the base of the PR and between 2e25d4c and 3fccff1.

📒 Files selected for processing (1)
  • docs/docs/administration-and-security/access-control/scim.md

Comment thread docs/docs/administration-and-security/access-control/scim.md

@emyller emyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26
khvn26 merged commit 3a496c3 into main Aug 5, 2026
12 checks passed
@khvn26
khvn26 deleted the docs/scim-okta-feedback branch August 5, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants