Skip to content

fix(tests): make segment rule and condition ordering deterministic #8454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewelwell merged 3 commits into from
Sep 4, 2026
+5 −0
Merged

fix(tests): make segment rule and condition ordering deterministic #8454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe2107
fix(tests): make segment rule and condition ordering deterministic
matthewelwell Sep 3, 2026
3ce2aee
Improve comment
matthewelwell Sep 4, 2026
744fff3
Merge branch 'main' into fix/deterministic-segment-ordering-in-tests
matthewelwell Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/app/settings/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
INSTALLED_APPS = INSTALLED_APPS + ["flagsmith_ldap"]
LDAP_DEFAULT_FLAGSMITH_ORGANISATION_ID = None

# Otherwise rule and condition ordering is whatever the database returns.
# Can cause issues downstream when using other database engines.
SEGMENT_CONDITIONS_EXPLICIT_ORDERING_ENABLED = True
SEGMENT_RULES_EXPLICIT_ORDERING_ENABLED = True

# We dont want to track tests
ENABLE_TELEMETRY = False
MAX_PROJECTS_IN_FREE_PLAN = 10
Expand Down
Loading