Skip to content

Conversation

@tomholub
Copy link
Collaborator

@tomholub tomholub commented Jan 7, 2023

This PR reverts change of behavior introduced in issue #4348 without reverting all of the general code / refactoring changes. Various parts of the code can still handle sending more than one actual message per "send button" click, which may still come handy, with a note to refactor it away in year 2024 if it remains unused.

close #4870
close #4702 - I also fixed this as a byproduct. Since it's a single message sent to pubkey recipients and to password link recipients, as before, it does make sense again to attach the files to it (since we only have to upload them once, not once per recipient), which is what I've done.


Tests (delete all except exactly one):

  • Tests added or updated (WIP)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub
Copy link
Collaborator Author

tomholub commented Jan 7, 2023

behavior looks good

Copy link
Collaborator Author

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@tomholub tomholub marked this pull request as ready for review January 10, 2023 19:14
@tomholub tomholub requested a review from sosnovsky January 10, 2023 19:14
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sosnovsky sosnovsky merged commit f043553 into master Jan 10, 2023
@sosnovsky sosnovsky deleted the issue-4870-revert-individual-fes-msgs branch January 10, 2023 19:41
tomholub added a commit that referenced this pull request Jan 11, 2023
tomholub added a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert one message per FES recipient attachments not sent through email provider for fes message

4 participants