Re-enable the documentation checks - #8024
Open
dimitrieh wants to merge 3 commits into
Open
Conversation
Restores docs.yml to its state before the checks were disabled. With both jobs skipped, publish was skipped too, so merging a docs change no longer triggered a website rebuild and docs only went live on the website's daily cron. test-with-website needs FlowFuse/website#5473 to merge first: it relies on the website build picking up the sibling flowfuse checkout, which is what that PR restores.
Contributor
Author
|
comment with context at FlowFuse/website#5432 (comment) |
Contributor
|
@dimitrieh we can't just re-enable them, those steps need fixing first to use the new website process. |
Contributor
Author
|
True, this needs to be merged in order after FlowFuse/website#5473 as defined in the comment and in the body of this pr |
An unescaped ( ends a markdown link target, so #enable-https-(optional) and #setting-up-mosquitto-(optional) point at nothing and leave a stray ) in the text. The rendered ids are enable-https-optional and setting-up-mosquitto-optional.
dimitrieh
changed the title
ZJvandeWeg
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the two
if: falselines, so the doc link checks run again and broken links get caught before publishing.Merge after FlowFuse/website#5473.
test-with-websiteneeds that PR in order to build a docs PR against its own docs. Before it, this fails onMissing script: "docs".Should also restore the
needsonpublishthat #8029 drops.testis blocked by something unrelated and repo-wide:npm cirejects the lockfile withlock file's globals@17.8.0 does not satisfy globals@17.9.0.Build and contenerizefails the same way.Also fixes five broken
(optional)anchors indocs/. An unescaped(ends a markdown link target, so they point at nothing. They are also what makes this PR's own checks run, since the workflow only triggers ondocs/**.