Let docs publish run while the checks are disabled - #8029
Merged
Conversation
A skipped job skips whatever needs it, so disabling test and test-with-website also stopped publish, and merging a docs change no longer triggered a website rebuild. Docs have been reaching production only on the website's own build schedule since. Dropping the needs restores the trigger. It goes back when the two checks do.
ZJvandeWeg
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging a
docs/**change used to trigger a website rebuild. It stopped, becausepublishwaits on the two doc checks, those checks are switched off, and GitHub skips any job that waits on a skipped one. Docs now only reach the site when the website rebuilds for its own reasons.Dropping the wait restores the trigger.
Only observable after merging:
publishruns on pushes tomain, never on a PR.Re-enabling the checks is separate work in #8024, which should put the wait back.