Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @param {import('express').Response} response | ||
| * @param {import('express').NextFunction} next | ||
| */ | ||
| async function authenticationCallback(context, options, request, response, next) { |
There was a problem hiding this comment.
Function authenticationCallback has 5 arguments (exceeds 4 allowed). Consider refactoring.
| * @param {import('express').Response} response | ||
| * @param {import('express').NextFunction} next | ||
| */ | ||
| async function authenticationCallback(context, options, request, response, next) { |
There was a problem hiding this comment.
Function authenticationCallback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
|
|
||
| get modelsDir() { | ||
| return this.lianaOptions && this.lianaOptions.modelsDir; | ||
| validateOptions() { |
There was a problem hiding this comment.
Function validateOptions has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
|
|
||
| get modelsDir() { | ||
| return this.lianaOptions && this.lianaOptions.modelsDir; | ||
| validateOptions() { |
There was a problem hiding this comment.
Function validateOptions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
| /** | ||
| * @param {import("../context/init").Context} context | ||
| */ | ||
| constructor({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit f03f3d0 and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 78.7% (49% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (2.5% change). View more on Code Climate. |
|
🎉 This PR is included in version 8.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [8.0.0](v7.10.1...v8.0.0) (2021-02-22) ### Bug Fixes * **authentication:** error when authenticating with an invalid token in cookies ([#611](#611)) ([e6d6737](e6d6737)) * send back response to frontend instead of redirecting ([#609](#609)) ([6f37521](6f37521)) * user being disconnected after 33min instead of 14 days ([#610](#610)) ([80580e7](80580e7)) * **auth:** oidc authentication when running multiple instances of the agent ([#608](#608)) ([ef25acb](ef25acb)) ### Features * merge master into beta ([131cb73](131cb73)) * **authentication:** remove old authentication routes ([#624](#624)) ([b0ffc50](b0ffc50)) * **authentication:** return a specific error during authorization if received an error about 2FA ([#622](#622)) ([3a59a12](3a59a12)) * **permissions:** handle mutliple permissions cache ([7114244](7114244)) * authenticate with openid connect ([#555](#555)) ([72b2cc8](72b2cc8)) * delete cookie when client logout ([#545](#545)) ([#560](#560)) ([5188206](5188206)) * feat!: ease the multi-database setup by providing a map of connections on liana.init (#525) ([2e9dc94](2e9dc94)), closes [#525](#525) ### BREAKING CHANGES * **authentication:** all previous authentication routes have been removed * onlyCrudModule, modelsDir, secretKey, authKey options are not supported anymore by Liana.init(). Instead of sequelize/mongoose & Sequelize/Mongoose, connections & objectMapping are now required.
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Pull Request checklist: