Skip to content

fix(auth): oidc authentication when running multiple instances of the agent#608

Merged
DrRaider merged 6 commits intobetafrom
fix/fix-oidc-auth-on-multiple-node-instances
Dec 30, 2020
Merged

fix(auth): oidc authentication when running multiple instances of the agent#608
DrRaider merged 6 commits intobetafrom
fix/fix-oidc-auth-on-multiple-node-instances

Conversation

@DrRaider
Copy link
Contributor

@DrRaider DrRaider commented Dec 29, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

VincentMolinie
VincentMolinie reviewed Dec 30, 2020
View reviewed changes
LouisClisson
LouisClisson approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@LouisClisson LouisClisson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅  Code review

👍

✅  Automatic tests

👍

✅  Manual tests

I tested the authentication flow and the current changes does not change the behavior. The fix should allow us to use oidc with agent running on multiple instance

✅  PR title

👍

@DrRaider DrRaider merged commit ef25acb into beta Dec 30, 2020
@DrRaider DrRaider deleted the fix/fix-oidc-auth-on-multiple-node-instances branch December 30, 2020 13:42
forest-bot added a commit that referenced this pull request Dec 30, 2020
@forest-bot
chore(release): 8.0.0-beta.8 [skip ci]
62b19e2 
# [8.0.0-beta.8](v8.0.0-beta.7...v8.0.0-beta.8) (2020-12-30)

### Bug Fixes

* **auth:** oidc authentication when running multiple instances of the agent ([#608](#608)) ([ef25acb](ef25acb))
@forest-bot
Copy link
Member

forest-bot commented Dec 30, 2020

🎉 This PR is included in version 8.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 22, 2021
@forest-bot
chore(release): 8.0.0 [skip ci]
d3bfb35 
# [8.0.0](v7.10.1...v8.0.0) (2021-02-22)

### Bug Fixes

* **authentication:** error when authenticating with an invalid token in cookies ([#611](#611)) ([e6d6737](e6d6737))
* send back response to frontend instead of redirecting ([#609](#609)) ([6f37521](6f37521))
* user being disconnected after 33min instead of 14 days ([#610](#610)) ([80580e7](80580e7))
* **auth:** oidc authentication when running multiple instances of the agent ([#608](#608)) ([ef25acb](ef25acb))

### Features

* merge master into beta ([131cb73](131cb73))
* **authentication:** remove old authentication routes ([#624](#624)) ([b0ffc50](b0ffc50))
* **authentication:** return a specific error during authorization if received an error about 2FA ([#622](#622)) ([3a59a12](3a59a12))
* **permissions:** handle mutliple permissions cache ([7114244](7114244))
* authenticate with openid connect ([#555](#555)) ([72b2cc8](72b2cc8))
* delete cookie when client logout ([#545](#545)) ([#560](#560)) ([5188206](5188206))

* feat!: ease the multi-database setup by providing a map of connections on liana.init (#525) ([2e9dc94](2e9dc94)), closes [#525](#525)

### BREAKING CHANGES

* **authentication:** all previous authentication routes have been removed
* onlyCrudModule, modelsDir, secretKey, authKey options are not supported anymore by Liana.init().
Instead of sequelize/mongoose & Sequelize/Mongoose, connections & objectMapping are now required.
@forest-bot
Copy link
Member

forest-bot commented Feb 22, 2021

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@GuillaumeCisco
fix: fix unconventional pk when referenced as null on creation (#608)
af70d62
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@forest-bot
chore(release): 6.7.6 [skip ci]
af64385 
## [6.7.6](ForestAdmin/forest-express-sequelize@v6.7.5...v6.7.6) (2021-02-02)

### Bug Fixes

* fix unconventional pk when referenced as null on creation ([#608](ForestAdmin/forest-express-sequelize#608)) ([af70d62](ForestAdmin/forest-express-sequelize@af70d62))
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@forest-bot
chore(release): 7.0.0-beta.10 [skip ci]
e4213d7 
# [7.0.0-beta.10](ForestAdmin/forest-express-sequelize@v7.0.0-beta.9...v7.0.0-beta.10) (2021-02-09)

### Bug Fixes

* array display with smart field ([#575](ForestAdmin/forest-express-sequelize#575)) ([e0698d3](ForestAdmin/forest-express-sequelize@e0698d3))
* correctly set fields holding  belongsTo relationships to null when updated with a null value ([#607](ForestAdmin/forest-express-sequelize#607)) ([374151f](ForestAdmin/forest-express-sequelize@374151f))
* display correct reference field when it is a smartfield ([#584](ForestAdmin/forest-express-sequelize#584)) ([50aef31](ForestAdmin/forest-express-sequelize@50aef31))
* fix belongsTo relationships creation when creating a record ([#602](ForestAdmin/forest-express-sequelize#602)) ([e06dbc8](ForestAdmin/forest-express-sequelize@e06dbc8))
* fix related data list display ([#578](ForestAdmin/forest-express-sequelize#578)) ([370dba7](ForestAdmin/forest-express-sequelize@370dba7))
* fix unconventional pk when referenced as null on creation ([#608](ForestAdmin/forest-express-sequelize#608)) ([af70d62](ForestAdmin/forest-express-sequelize@af70d62))
* handle foreign key toward non primary key ([#585](ForestAdmin/forest-express-sequelize#585)) ([64c78c7](ForestAdmin/forest-express-sequelize@64c78c7))
* secure sql queries generated by leaderboard stats ([#611](ForestAdmin/forest-express-sequelize#611)) ([f41d79c](ForestAdmin/forest-express-sequelize@f41d79c))
* **forestadmin-schema:** regenerate forestadmin schema only when files are valid ([#597](ForestAdmin/forest-express-sequelize#597)) ([a24abbd](ForestAdmin/forest-express-sequelize@a24abbd))
* **leaderboard:** fix an error when use "user" table ([#565](ForestAdmin/forest-express-sequelize#565)) ([0cbbc32](ForestAdmin/forest-express-sequelize@0cbbc32))
* **smart-action-hook:** value injected to an enum field of type  is now correctly handled ([#600](ForestAdmin/forest-express-sequelize#600)) ([c0a3b58](ForestAdmin/forest-express-sequelize@c0a3b58))

### Features

* **filter:** add possibility to filter on smart field ([eaead56](ForestAdmin/forest-express-sequelize@eaead56))
* **filter:** add possibility to filter on smart field ([#583](ForestAdmin/forest-express-sequelize#583)) ([dbf136a](ForestAdmin/forest-express-sequelize@dbf136a))
* **smart actions:** introduce smart action forms hooks ([#569](ForestAdmin/forest-express-sequelize#569)) ([cd13029](ForestAdmin/forest-express-sequelize@cd13029))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VincentMolinie VincentMolinie VincentMolinie left review comments

+1 more reviewer

@LouisClisson LouisClisson LouisClisson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DrRaider DrRaider

@LouisClisson LouisClisson

Labels

released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DrRaider @forest-bot @VincentMolinie @LouisClisson

Comments