fix: user being disconnected after 33min instead of 14 days#610
Merged
Conversation
Member
LouisClisson
approved these changes
Jan 6, 2021
Contributor
LouisClisson
left a comment
LouisClisson
left a comment
There was a problem hiding this comment.
✅ Code review
👌
✅ Automatic tests
👌
✅ Manual tests
I tested twice (with the fix and without) and the cookie expiration date is well set to 14 days. Congrats
✅ PR title
👌
🚀🚀
forest-bot
added a commit
that referenced
this pull request
Jan 6, 2021
# [8.0.0-beta.10](v8.0.0-beta.9...v8.0.0-beta.10) (2021-01-06) ### Bug Fixes * user being disconnected after 33min instead of 14 days ([#610](#610)) ([80580e7](80580e7))
Member
|
🎉 This PR is included in version 8.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Feb 22, 2021
# [8.0.0](v7.10.1...v8.0.0) (2021-02-22) ### Bug Fixes * **authentication:** error when authenticating with an invalid token in cookies ([#611](#611)) ([e6d6737](e6d6737)) * send back response to frontend instead of redirecting ([#609](#609)) ([6f37521](6f37521)) * user being disconnected after 33min instead of 14 days ([#610](#610)) ([80580e7](80580e7)) * **auth:** oidc authentication when running multiple instances of the agent ([#608](#608)) ([ef25acb](ef25acb)) ### Features * merge master into beta ([131cb73](131cb73)) * **authentication:** remove old authentication routes ([#624](#624)) ([b0ffc50](b0ffc50)) * **authentication:** return a specific error during authorization if received an error about 2FA ([#622](#622)) ([3a59a12](3a59a12)) * **permissions:** handle mutliple permissions cache ([7114244](7114244)) * authenticate with openid connect ([#555](#555)) ([72b2cc8](72b2cc8)) * delete cookie when client logout ([#545](#545)) ([#560](#560)) ([5188206](5188206)) * feat!: ease the multi-database setup by providing a map of connections on liana.init (#525) ([2e9dc94](2e9dc94)), closes [#525](#525) ### BREAKING CHANGES * **authentication:** all previous authentication routes have been removed * onlyCrudModule, modelsDir, secretKey, authKey options are not supported anymore by Liana.init(). Instead of sequelize/mongoose & Sequelize/Mongoose, connections & objectMapping are now required.
Member
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to CU-c50kbn
Pull Request checklist: