feat(email): rename Reply -> Needs Reply everywhere (mig 92 + ingest canonicalisation) - #168
Merged
Conversation
…g 92) A bare "Reply" reads as a verb/button, not a state. The conversation-status label becomes "Needs Reply" across rules, labels, analytics, presets, and the mailbox mirror. Follows the To-Reply->Reply rename playbook exactly: - mig 92 rewrites what we own (rule name, LABEL action, categories arrays) - persist._RENAMED_LABELS canonicalises AT INGEST — the categories-authoritative provider re-asserts old labels every sync, so a one-time rewrite alone would be resurrected; mapping at ingest makes the rename stick while the reconciler replaces provider-side labels over time - legacy aliases kept everywhere a token/name/label resolves (_LEGACY_STATUS_KEYS += NEEDS_REPLY, _CONVERSATION_SYSTEM_KEYS, _LEGACY_CONVERSATION_LABELS += "Reply", preset-install legacy-alias skip, auto-draft rule lookup) - frontend: QuickFilters chip + preset template 836 email unit tests green (rename-legacy suite extended: ingest canonicalisation + needs-reply-name resolution pins). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 23, 2026
vjvarada
added a commit
that referenced
this pull request
Jul 23, 2026
…ule (#177) * feat(email): one rules screen — learned patterns nested under their rule The engine already runs one pipeline (patterns deterministically first, AI classifier second), but the VIEW was split: rules in the Rules tab, the patterns that pre-empt them in Settings. Now each rule card discloses its own learned patterns (with pending-review state, approve/reject/forget inline — the same PatternRow the Settings screen uses, so the surfaces can't drift), and the tab header states the actual execution order, ending at the Uncategorized pill / Fix flow that teaches new ones. Storage stays separate on purpose: merging patterns into rule conditions would lose the approval gate (#96/#97) and the per-pattern provenance. Also fixes stale "Reply" in the empty-state copy (missed in the #168 rename). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(email): record second-wave ships in the master plan; strike Dismiss from v2 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare "Reply" reads as a verb/button, not a state. The conversation-status
label becomes "Needs Reply" across rules, labels, analytics, presets, and the
mailbox mirror.
Follows the To-Reply->Reply rename playbook exactly:
provider re-asserts old labels every sync, so a one-time rewrite alone would
be resurrected; mapping at ingest makes the rename stick while the
reconciler replaces provider-side labels over time
(_LEGACY_STATUS_KEYS += NEEDS_REPLY, _CONVERSATION_SYSTEM_KEYS,
_LEGACY_CONVERSATION_LABELS += "Reply", preset-install legacy-alias skip,
auto-draft rule lookup)
836 email unit tests green (rename-legacy suite extended: ingest
canonicalisation + needs-reply-name resolution pins).
Co-Authored-By: Claude Fable 5 noreply@anthropic.com