feat(email): one rules screen — learned patterns nested under their rule - #177
Merged
Conversation
The engine already runs one pipeline (patterns deterministically first, AI classifier second), but the VIEW was split: rules in the Rules tab, the patterns that pre-empt them in Settings. Now each rule card discloses its own learned patterns (with pending-review state, approve/reject/forget inline — the same PatternRow the Settings screen uses, so the surfaces can't drift), and the tab header states the actual execution order, ending at the Uncategorized pill / Fix flow that teaches new ones. Storage stays separate on purpose: merging patterns into rule conditions would lose the approval gate (#96/#97) and the per-pattern provenance. Also fixes stale "Reply" in the empty-state copy (missed in the #168 rename). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…iss from v2 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The consolidation the user asked for — "everything can be seen in one place" — done at the view layer, keeping the stores separate (the approval gate #96/#97 and per-pattern provenance survive).
PatternRowcomponent the Settings screen uses (now exported), with the same verbs: approve/reject for pending auto-learned ones, reject/forget for in-force ones. Rejected patterns stay records-only in Settings.Frontend-only;
listRulePatternsalready returnsrule_id, so no backend change.tsc --noEmitclean; no import cycle (SettingsTab does not import RulesTab).🤖 Generated with Claude Code