Skip to content

Fix #288 #143 and deprecated gtk_widget_reparent()#289

Merged
antenore merged 3 commits into
FreeRDP:gtk3from
giox069:gtk3
Aug 4, 2014
Merged

Fix #288 #143 and deprecated gtk_widget_reparent()#289
antenore merged 3 commits into
FreeRDP:gtk3from
giox069:gtk3

Conversation

@giox069
Copy link
Copy Markdown
Contributor

@giox069 giox069 commented Aug 4, 2014

No description provided.

@giox069 giox069 changed the title Fix #288 #144 and deprecated gtk_widget_reparent() Fix #288 #143 and deprecated gtk_widget_reparent() Aug 4, 2014
antenore added a commit that referenced this pull request Aug 4, 2014
Fix #288 #143 and deprecated gtk_widget_reparent()
@antenore antenore merged commit 4307f52 into FreeRDP:gtk3 Aug 4, 2014
@antenore
Copy link
Copy Markdown
Member

antenore commented Aug 4, 2014

Good job! Merged

@giox069
Copy link
Copy Markdown
Contributor Author

giox069 commented Aug 4, 2014

It's still a bit hard for me, I'm still learning and fighting against all these new tools for me: git, github, gtk, libfreerdp. But I'm having fun :)

@dupondje
Copy link
Copy Markdown
Contributor

dupondje commented Aug 4, 2014

Not to complain, but please watch the indentation.
This way we can keep clean & easy to read code! :)

@giox069
Copy link
Copy Markdown
Contributor Author

giox069 commented Aug 4, 2014

@dupondje ok. Forgive me. As said... I'm still new, I'm not a professional programmer, just be patient. Are you talking about indentation in the central part of remmina_connection_window.c diff ? Should I do another pull request ?

@dupondje
Copy link
Copy Markdown
Contributor

dupondje commented Aug 4, 2014

As I told, its not a big issue :) Just if we want to keep it clean, its nice to have indent correct.
Its indeed the part in the remmina_connection_window.c. Feel free to create another pull request for that.
Anyway no complaints :). We are already happy somebody actually makes time to contribute!

@antenore
Copy link
Copy Markdown
Member

antenore commented Aug 4, 2014

@giox069, @dupondje Didn't see the double tab identation as well :-( . It's your first commit on remmina_connection_window.c.

BTW, as I'm new as well, how we should proceed to merge all of these changes in the master, without breaking everything?

@antenore antenore added this to the v1.0.1 milestone Aug 20, 2014
antenore added a commit that referenced this pull request Jul 10, 2015
Fix #288 #143 and deprecated gtk_widget_reparent()
antenore added a commit that referenced this pull request Jul 10, 2015
Fix #288 #143 and deprecated gtk_widget_reparent()
antenore added a commit that referenced this pull request Jul 10, 2015
Fix #288 #143 and deprecated gtk_widget_reparent()
jbicha pushed a commit to jbicha/Remmina that referenced this pull request Jun 12, 2016
Fix #288 #143 and deprecated gtk_widget_reparent()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants