Fix app indicator when using custom install prefix#48
Merged
Conversation
When Remmina is installed to a custom location (e.g. when using 'cmake -DCMAKE_INSTALL_PREFIX=/opt/remmina') the app indicator applet in Unity doesn't display because it tries to load the icon from one of the standard icon theme locations (e.g. /usr/share/icons, etc). When it doesn't find the Remmina icon, the app indicator is not displayed in the notification panel. With this commit, the app indicator is configured to look in the correct location for the icon. As a result, the app indicator properly loads into the notification panel.
awakecoding
added a commit
that referenced
this pull request
Apr 23, 2012
Fix app indicator when using custom install prefix
awakecoding
added a commit
that referenced
this pull request
Jul 10, 2015
Fix app indicator when using custom install prefix
awakecoding
added a commit
that referenced
this pull request
Jul 10, 2015
Fix app indicator when using custom install prefix
jbicha
pushed a commit
to jbicha/Remmina
that referenced
this pull request
Jun 12, 2016
Fix app indicator when using custom install prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what the preferred method is for sending a patch to Remmina (in this case a 1 line patch), so let me know if there is another preferred method besides a pull request (e.g. emailing a patch).
When Remmina is installed to a custom location (e.g. when using
'cmake -DCMAKE_INSTALL_PREFIX=/opt/remmina') the app indicator applet in Unity doesn't display because it tries to load the icon from one of the standard icon theme locations (e.g. /usr/share/icons, etc). When it
doesn't find the Remmina icon, the app indicator is not displayed in the notification panel. With this commit, the app indicator is configured to look in the correct location for the icon. As a result, the app indicator properly loads into the notification panel.