Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog#501
Merged
Conversation
… should show the resolutions dialog
Contributor
There was a problem hiding this comment.
This thing, duplicated between preferences dialog and file editor could be moved in remmina_public to avoid code duplication.
Contributor
|
This is great, @antenore |
Member
Author
|
Thanks @muflone . I'll work on it the next days. |
Contributor
|
@antenore |
Member
Author
|
Don't worry @muflone , go ahead, . I'll solve the conflicts. I still cannot work on Remmina for some days. |
Added translations to ignore certificate Added cert_ignore for RDP plugin Don't set gateway_usage_method for non RD gateway connections Added second column data string_list, use two_columns argument during the creation Removed samples data Added RD Gateway server setting Code cleanup Restored icon in the external tools menu item Merge pull request #505 from FreeRDP/Issues/503 Code cleanup Added a new preference to show or hide the menu icons Added a new preference to show or hide the buttons icons Renamed preferences widgets from options to appearance Added appearance page in preferences dialog Merge pull request #500 from KyleSanderson/memleak Merge pull request #502 from ozbek/next Add translations for Uzbek Cyrillic Fix small memory leaks and a NULL ptr dereference.
Member
Author
Contributor
|
Seems fine to me, you can merge it |
antenore
added a commit
that referenced
this pull request
Mar 2, 2015
Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog
antenore
added a commit
that referenced
this pull request
Jul 10, 2015
Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog
antenore
added a commit
that referenced
this pull request
Jul 10, 2015
Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog
antenore
added a commit
that referenced
this pull request
Jul 10, 2015
Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog
antenore
added a commit
that referenced
this pull request
Jul 10, 2015
Fixes FreeRDP/Remmina#473 - Customize button in the connection editor should show the resolutions dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@muflone it works, but I'm not sure about the quality of the code. Can you please review it?
Thanks in advance