Bugfixes for EvaluateModel and MatFileSampler#168
Merged
kathyxchen merged 7 commits intoFunctionLab:masterfrom Jun 7, 2021
Merged
Bugfixes for EvaluateModel and MatFileSampler#168kathyxchen merged 7 commits intoFunctionLab:masterfrom
kathyxchen merged 7 commits intoFunctionLab:masterfrom
Conversation
jzthree
approved these changes
Jun 6, 2021
Contributor
jzthree
left a comment
jzthree
left a comment
There was a problem hiding this comment.
This looks good! Maybe just add a sentence in data_sampler doc that if the use_features_ord is specified, the returned target from data_sampler can be optionally containing only the subset of features specified in use_features_ord and ordered in the same order as in features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes bugs in EvaluateModel
use_features_ordfunctionality (evaluating a model on only a subset of ordered targets) and MatFileSampler, which reset the pointer to what row to sample too early (i.e. supposed to do it when you've sampled all the rows in the matrix)What does this implement/fix? Explain your changes.
See above
What testing did you do to verify the changes in this PR?
Ran EvaluateModel using MatFileSampler input data on 2 different cases, 1 subsetting chromatin features and 1 using the full set of features predicted by the model.