Capitalise the salutation on the bonafide certificate - #1976
Merged
vikrantwiz02 merged 1 commit intoSep 2, 2026
Merged
Conversation
The certificate addressed students as Mr. or Ms. and the father as Mr., which reads inconsistently beside the rest of the document where names and headings are set in capitals. Both forms are now MR. and MS., for either gender and in every place they appear -- the student's name in both sentences and the father's name in the parentage line. D/o and S/o and the pronoun are left as they are; they are not salutations.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bonafide certificate addressed the student as
Mr.orMs.and the father asMr., which reads inconsistently beside the rest of the document, where names and headings are set in capitals.Both are now
MR.andMS., for either gender and in every place a salutation appears:This is to certify that …This certificate is being issued to …D/o/S/oand thehis/herpronoun are unchanged — they are not salutations and are conventionally mixed case. AnyMr./Shri/Srialready stored on the father's name is still stripped beforeMR.is prepended, so a storedMr. …does not render asMR. Mr. ….Verified by rendering the certificate for a real student of each gender and reading the text back out of the PDF:
MS.x2 (both sentences) +MR.x1 (father)D/oMR.x3 (student twice, father once)S/oNo mixed-case
Mr.orMs.remains in either. The three affected assertions intest_bonafide_certificate.pyare updated to match; note the backend test database cannot be built in this checkout — aRunSQLstep in the migration history referencescourse_registrationbefore it is created, which is pre-existing — so the PDF render above is the verification.manage.py checkclean, no migrations.