Skip to content

HeightMap: Enhance pointer validation for vertex and index buffers #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
Oct 10, 2025
Merged

HeightMap: Enhance pointer validation for vertex and index buffers #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/HeightMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4327,7 +4327,9 @@ void HeightMapRenderObjClass::renderExtraBlendTiles(void)
DynamicIBAccessClass::WriteLockClass lockib(&ib_access);
UnsignedShort *ib=lockib.Get_Index_Array();

if (!vb || !ib) return;
// Enhanced pointer validation: check for NULL and suspiciously low addresses that indicate
// invalid/corrupted pointers from failed buffer allocation or device in degraded state
if (!vb || !ib || (size_t)vb < 0x10000 || (size_t)ib < 0x10000) return;

const UnsignedByte* data = m_map->getDataPtr();

Expand Down
4 changes: 3 additions & 1 deletion GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/HeightMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2267,7 +2267,9 @@ void HeightMapRenderObjClass::renderExtraBlendTiles(void)
DynamicIBAccessClass::WriteLockClass lockib(&ib_access);
UnsignedShort *ib=lockib.Get_Index_Array();

if (!vb || !ib) return;
// Enhanced pointer validation: check for NULL and suspiciously low addresses that indicate
// invalid/corrupted pointers from failed buffer allocation or device in degraded state
if (!vb || !ib || (size_t)vb < 0x10000 || (size_t)ib < 0x10000) return;

const UnsignedByte* data = m_map->getDataPtr();

Expand Down
Loading